# fix module\_param in rivafb

- From: Guido Guenther \<agx@sigxcpu.org\>
- Date: 2004-11-20 00:48:14 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2004/11/13454030
- Thread: https://ratatoskr.run/linux-fbdev/2004/11/13454030/t.md

```text
Hi Tony,
third argument in module_param is the sysfs permission not a default
value. This fixes things for rivafb in 2.6.10-rc2:
Signed-Off-By: Guido Guenther <agx@sigxcpu.org>

--- linux-2.6.10-rc2.orig/drivers/video/riva/fbdev.c	2004-11-17 17:33:53.000000000 +0100
+++ linux-2.6.10-rc2/drivers/video/riva/fbdev.c	2004-11-20 01:38:47.017282552 +0100
@@ -2183,9 +2195,9 @@
 
 module_param(noaccel, bool, 0);
 MODULE_PARM_DESC(noaccel, "bool: disable acceleration");
-module_param(flatpanel, int, -1);
+module_param(flatpanel, int, 0);
 MODULE_PARM_DESC(flatpanel, "Enables experimental flat panel support for some chipsets. (0 or 1=enabled) (default=0)");
-module_param(forceCRTC, int, -1);
+module_param(forceCRTC, int, 0);
 MODULE_PARM_DESC(forceCRTC, "Forces usage of a particular CRTC in case autodetection fails. (0 or 1) (default=autodetect)");
 #ifdef CONFIG_MTRR
 module_param(nomtrr, bool, 0);

Cheers,
 -- Guido


-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
```
