[PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor()

STALE7944d

6 messages, 3 authors, 2004-11-03 · open the first message on its own page

[PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor()

From: Antonino A. Daplas <hidden>
Date: 2004-11-02 11:47:19

atyfb_base.c requires atyfb_cursor, but it is only available for linking
if CONFIG_FB_ATY_CT=y.
This patch moves the .o file to the CONFIG_FB_ATY rule.

Signed-off-by: Olaf Hering <redacted>
Signed-off-by: Antonino Daplas <redacted>
---

 Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -Nru a/drivers/video/aty/Makefile b/drivers/video/aty/Makefile
--- a/drivers/video/aty/Makefile	2004-10-19 20:22:37 +08:00
+++ b/drivers/video/aty/Makefile	2004-11-01 22:42:04 +08:00
@@ -2,9 +2,9 @@
 obj-$(CONFIG_FB_ATY128) += aty128fb.o
 obj-$(CONFIG_FB_RADEON) += radeonfb.o
 
-atyfb-y				:= atyfb_base.o mach64_accel.o
+atyfb-y				:= atyfb_base.o mach64_accel.o mach64_cursor.o
 atyfb-$(CONFIG_FB_ATY_GX)	+= mach64_gx.o
-atyfb-$(CONFIG_FB_ATY_CT)	+= mach64_ct.o mach64_cursor.o
+atyfb-$(CONFIG_FB_ATY_CT)	+= mach64_ct.o
 atyfb-objs			:= $(atyfb-y)
 
 radeonfb-y			:= radeon_base.o radeon_pm.o radeon_monitor.o radeon_accel.o




-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click

S1D13506 CRT

From: ramprasad <hidden>
Date: 2004-11-02 13:06:05

Hi All,
    I am using 2.4.19-rmk7-pxa1 kernel.I have  an S1D13506 LCD/CRT 
controller. has anybody got  this working on PXA processor.any hint on 
how to  go about. I have to configure for CRT display.


Thanks in advance,
Ramprasad



-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click

Re: [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor()

From: Ville Syrjälä <syrjala@sci.fi>
Date: 2004-11-02 13:58:47

On Tue, Nov 02, 2004 at 07:46:26PM +0800, Antonino A. Daplas wrote:
atyfb_base.c requires atyfb_cursor, but it is only available for linking
if CONFIG_FB_ATY_CT=y.
This patch moves the .o file to the CONFIG_FB_ATY rule.
Here's a better fix. It was a part of my swcursor patch which was 
partially included. Looks like Alex accidentally dropped this part.


Fix atyfb cursor problems:
- oops with noaccel option
- CONFIG_FB_ATY_CT dependency problem

Signed-off-by: Ville Syrjala <syrjala@sci.fi>
---

 atyfb_base.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -Nur a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
--- a/drivers/video/aty/atyfb_base.c	2004-11-02 15:20:23.199495000 +0200
+++ b/drivers/video/aty/atyfb_base.c	2004-11-02 15:22:20.979495000 +0200
@@ -292,7 +292,7 @@
 	.fb_fillrect	= atyfb_fillrect,
 	.fb_copyarea	= atyfb_copyarea,
 	.fb_imageblit	= atyfb_imageblit,
-	.fb_cursor	= atyfb_cursor,
+	.fb_cursor	= soft_cursor,
 #ifdef __sparc__
 	.fb_mmap	= atyfb_mmap,
 #endif
-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/


-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id065&op=click

Re: [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor()

From: Antonino A. Daplas <hidden>
Date: 2004-11-02 21:31:49

On Tuesday 02 November 2004 21:58, Ville Syrjälä wrote:
On Tue, Nov 02, 2004 at 07:46:26PM +0800, Antonino A. Daplas wrote:
quoted
atyfb_base.c requires atyfb_cursor, but it is only available for linking
if CONFIG_FB_ATY_CT=y.
This patch moves the .o file to the CONFIG_FB_ATY rule.
Here's a better fix. It was a part of my swcursor patch which was
partially included. Looks like Alex accidentally dropped this part.


Fix atyfb cursor problems:
- oops with noaccel option
- CONFIG_FB_ATY_CT dependency problem
If I read Alex's patch correctly, it looks like the aty has a working
hardware cursor implementation, is this correct?  Then a better patch may be
to use soft_cursor if noaccel is true, and atyfb_cursor otherwise.

Tony




-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id065&op=click

Re: [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor()

From: Ville Syrjälä <syrjala@sci.fi>
Date: 2004-11-02 22:26:47

On Wed, Nov 03, 2004 at 05:31:36AM +0800, Antonino A. Daplas wrote:
On Tuesday 02 November 2004 21:58, Ville Syrjälä wrote:
quoted
On Tue, Nov 02, 2004 at 07:46:26PM +0800, Antonino A. Daplas wrote:
quoted
atyfb_base.c requires atyfb_cursor, but it is only available for linking
if CONFIG_FB_ATY_CT=y.
This patch moves the .o file to the CONFIG_FB_ATY rule.
Here's a better fix. It was a part of my swcursor patch which was
partially included. Looks like Alex accidentally dropped this part.


Fix atyfb cursor problems:
- oops with noaccel option
- CONFIG_FB_ATY_CT dependency problem
If I read Alex's patch correctly, it looks like the aty has a working
hardware cursor implementation, is this correct?  Then a better patch may be
to use soft_cursor if noaccel is true, and atyfb_cursor otherwise.
That is how things work with this patch. aty_init_cursor() sets fb_cursor 
to atyfb_cursor.

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/


-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id065&op=click

Re: [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor()

From: Antonino A. Daplas <hidden>
Date: 2004-11-03 02:40:16

On Wednesday 03 November 2004 06:26, Ville Syrjälä wrote:
On Wed, Nov 03, 2004 at 05:31:36AM +0800, Antonino A. Daplas wrote:
quoted
On Tuesday 02 November 2004 21:58, Ville Syrjälä wrote:
quoted
On Tue, Nov 02, 2004 at 07:46:26PM +0800, Antonino A. Daplas wrote:
quoted
atyfb_base.c requires atyfb_cursor, but it is only available for
linking if CONFIG_FB_ATY_CT=y.
This patch moves the .o file to the CONFIG_FB_ATY rule.
Here's a better fix. It was a part of my swcursor patch which was
partially included. Looks like Alex accidentally dropped this part.


Fix atyfb cursor problems:
- oops with noaccel option
- CONFIG_FB_ATY_CT dependency problem
If I read Alex's patch correctly, it looks like the aty has a working
hardware cursor implementation, is this correct?  Then a better patch may
be to use soft_cursor if noaccel is true, and atyfb_cursor otherwise.
That is how things work with this patch. aty_init_cursor() sets fb_cursor
to atyfb_cursor.
Ah, ok, did not see that.

Tony




-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id065&op=click
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help