Posted this last week (10/21) but haven't seen any response.
Would you consider this for the next -mm? Also attached in
case kmail mangles the whitespace.
[PATCH] radeonfb: If no video memory, exit with error
Nothing good will happen if we try to ioremap and use a zero-sized
frame buffer. I observed this problem on an ia64 sx1000 box, where
the BIOS doesn't run the option ROM. If we try to continue, radeonfb
just gets hopelessly confused because the card isn't initialized
correctly.
Signed-off-by: Bjorn Helgaas <redacted>
===== drivers/video/aty/radeon_base.c 1.32 vs edited =====
@@ -2186,7 +2186,9 @@rinfo->video_ram=8192*1024;break;default:-break;+printk(KERN_ERR"radeonfb: no video RAM reported\n");+ret=-ENXIO;+gotoerr_unmap_rom;}}
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: 2004-10-26 23:54:47
Andrew, looks ok.
On Tue, 2004-10-26 at 16:03 -0600, Bjorn Helgaas wrote:
quoted hunk
Posted this last week (10/21) but haven't seen any response.
Would you consider this for the next -mm? Also attached in
case kmail mangles the whitespace.
[PATCH] radeonfb: If no video memory, exit with error
Nothing good will happen if we try to ioremap and use a zero-sized
frame buffer. I observed this problem on an ia64 sx1000 box, where
the BIOS doesn't run the option ROM. If we try to continue, radeonfb
just gets hopelessly confused because the card isn't initialized
correctly.
Signed-off-by: Bjorn Helgaas <redacted>
===== drivers/video/aty/radeon_base.c 1.32 vs edited =====
@@ -2186,7 +2186,9 @@rinfo->video_ram=8192*1024;break;default:-break;+printk(KERN_ERR"radeonfb: no video RAM reported\n");+ret=-ENXIO;+gotoerr_unmap_rom;}}
--
Benjamin Herrenschmidt [off-list ref]
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: 2004-10-27 09:47:45
On Tue, 2004-10-26 at 16:03 -0600, Bjorn Helgaas wrote:
Posted this last week (10/21) but haven't seen any response.
Would you consider this for the next -mm? Also attached in
case kmail mangles the whitespace.
I did tell Andrew it was OK this morning.
Ben.
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click