2.6.7mm5: switching from X to fbdev gives wrong vertical frequency

3 messages, 2 authors, 2004-07-04 · open the first message on its own page

2.6.7mm5: switching from X to fbdev gives wrong vertical frequency

From: Jurriaan <hidden>
Date: 2004-07-04 13:37:38

I boot my kernel like this:

kernel /boot/vmlinuz-267mm5 root=/dev/md3 video=radeonfb:1600x1200-16@85 softrepeat=1

and that works fine in 2.6.7-mm5 with Davids 16bpp copyarea fix.

XFree also works fine (latest debian version:)

xfree86-common 4.3.0.dfsg.1-5 X Window System (XFree86) infrastructure
xserver-xfree8 4.3.0.dfsg.1-5 the XFree86 X server

In 2.6.7 both worked fine, and I could switch from X to fb and back
without any problem. Now, when I switch from X to fb, my 85 Hz refresh
is changed to 60. That looks really awful.

Jurriaan
-- 
I am Lwaxana Troi of Borg. Oh, Jean-Luc, what futile thoughts...
Debian (Unstable) GNU/Linux 2.6.7-mm5 2x6078 bogomips load 3.42


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com

Re: 2.6.7mm5: switching from X to fbdev gives wrong vertical frequency

From: Antonino A. Daplas <hidden>
Date: 2004-07-04 15:48:08

On Sunday 04 July 2004 21:36, Jurriaan wrote:
I boot my kernel like this:

kernel /boot/vmlinuz-267mm5 root=/dev/md3 video=radeonfb:1600x1200-16@85
softrepeat=1

and that works fine in 2.6.7-mm5 with Davids 16bpp copyarea fix.

XFree also works fine (latest debian version:)

xfree86-common 4.3.0.dfsg.1-5 X Window System (XFree86) infrastructure
xserver-xfree8 4.3.0.dfsg.1-5 the XFree86 X server

In 2.6.7 both worked fine, and I could switch from X to fb and back
without any problem. Now, when I switch from X to fb, my 85 Hz refresh
is changed to 60. That looks really awful.
Can you try this patch?

Tony

diff -Naur linux-2.6.7-mm5-orig/drivers/video/console/fbcon.c linux-2.6.7-mm5/drivers/video/console/fbcon.c
--- linux-2.6.7-mm5-orig/drivers/video/console/fbcon.c	2004-07-04 23:34:29.873322872 +0800
+++ linux-2.6.7-mm5/drivers/video/console/fbcon.c	2004-07-04 23:36:18.169859296 +0800
@@ -1679,8 +1679,7 @@
 	var.yres = height * fh;
 	x_diff = info->var.xres - var.xres;
 	y_diff = info->var.yres - var.yres;
-	if (x_diff < 0 || x_diff > fw || (y_diff < 0 || y_diff > fh) ||
-	    (info->flags & FBINFO_MISC_MODESWITCH)) {
+	if (x_diff < 0 || x_diff > fw || (y_diff < 0 || y_diff > fh)) {
 		char mode[40];
 
 		DPRINTK("attempting resize %ix%i\n", var.xres, var.yres);
@@ -1695,12 +1694,9 @@
 			return -EINVAL;
 		DPRINTK("resize now %ix%i\n", var.xres, var.yres);
 		if (CON_IS_VISIBLE(vc)) {
-			var.activate = FB_ACTIVATE_NOW |
-				(info->flags & FBINFO_MISC_MODESWITCH) ?
-				FB_ACTIVATE_FORCE : 0;
+			var.activate = FB_ACTIVATE_NOW;
 			fb_set_var(info, &var);
 		}
-		info->flags &= ~FBINFO_MISC_MODESWITCH;
 	}
 	updatescrollmode(p, info, vc);
 	return 0;
@@ -1752,6 +1748,13 @@
 	}
 
  	fbcon_resize(vc, vc->vc_cols, vc->vc_rows);
+
+	if (info->flags & FBINFO_MISC_MODESWITCH &&
+		info->fbops->fb_set_par) {
+		info->fbops->fb_set_par(info);
+	}
+	info->flags &= ~FBINFO_MISC_MODESWITCH;
+
 	switch (p->scrollmode) {
 	case SCROLL_WRAP:
 		scrollback_phys_max = p->vrows - vc->vc_rows;




-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com

Re: 2.6.7mm5: switching from X to fbdev gives wrong vertical frequency

From: Jurriaan <hidden>
Date: 2004-07-04 16:28:50

From: Antonino A. Daplas <redacted>
Date: Sun, Jul 04, 2004 at 11:47:53PM +0800
On Sunday 04 July 2004 21:36, Jurriaan wrote:
quoted
I boot my kernel like this:

kernel /boot/vmlinuz-267mm5 root=/dev/md3 video=radeonfb:1600x1200-16@85
softrepeat=1

and that works fine in 2.6.7-mm5 with Davids 16bpp copyarea fix.

XFree also works fine (latest debian version:)

xfree86-common 4.3.0.dfsg.1-5 X Window System (XFree86) infrastructure
xserver-xfree8 4.3.0.dfsg.1-5 the XFree86 X server

In 2.6.7 both worked fine, and I could switch from X to fb and back
without any problem. Now, when I switch from X to fb, my 85 Hz refresh
is changed to 60. That looks really awful.
Can you try this patch?
This patch solves my problem, I can switch back-and-forth between X and
the framebuffer with 2.6.7-mm5 without any problems.

Thanks,
Jurriaan
-- 
Join=20the=20campaign=20against=20excessive=20use=20of=20MIME=2e
Debian (Unstable) GNU/Linux 2.6.7-mm5 2x6078 bogomips load 3.60


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help