Actually its a bug in stty itself. stty only sets the row or column at a
time. So when you do a stty row col it is actually doing TWO mode sets.
One to change the number of rows then another to change the number of
columns. So to the fbdev driver it looks like this:
640x480 -> 1024x480 -> 1024x768
Now for alot of driver the middle setting doesn't work. So it fails.
This bug also effects serial consoles as well. I CC the stty maintain so
he can apply the below patch. It is against the latest GNU core utilites.
It fixes the issue.
--- stty.c.orig 2004-05-07 17:48:51.000000000 -0700
+++ stty.c 2004-05-07 18:00:36.000000000 -0700
@@ -733,6 +733,10 @@
int speed_was_set;
int verbose_output;
int recoverable_output;
+#ifdef TIOCGWINSZ
+ int size_was_set = 0;
+ int cols, rows;
+#endif
int k;
int noargs = 1;
char *file_name = NULL;
@@ -1004,8 +1008,8 @@
usage (EXIT_FAILURE);
}
++k;
- set_window_size ((int) integer_arg (argv[k]), -1,
- fd, device_name);
+ rows = integer_arg (argv[k]);
+ size_was_set = 1;
}
else if (STREQ (argv[k], "cols")
|| STREQ (argv[k], "columns"))
@@ -1016,8 +1020,8 @@
usage (EXIT_FAILURE);
}
++k;
- set_window_size (-1, (int) integer_arg (argv[k]),
- fd, device_name);
+ cols = integer_arg (argv[k]);
+ size_was_set = 1;
}
else if (STREQ (argv[k], "size"))
{@@ -1063,6 +1067,12 @@
k++;
}
+#ifdef TIOCGWINSZ
+ if (size_was_set)
+ {
+ set_window_size (rows, cols, fd, device_name);
+ }
+#endif
if (require_set_attr)
{
struct termios new_mode;
-------------------------------------------------------This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND
On Wed, 16 Jun 2004 jsimmons@pentafluge.infradead.org wrote:
Hi,
+#ifdef TIOCGWINSZ
+ int size_was_set = 0;
+ int cols, rows;
^^^^^^^^^^^^^^^
These should both be initialized to -1 because...
- set_window_size ((int) integer_arg (argv[k]), -1,
- fd, device_name);
+ rows = integer_arg (argv[k]);
+ size_was_set = 1;
[...]
- set_window_size (-1, (int) integer_arg (argv[k]),
- fd, device_name);
+ cols = integer_arg (argv[k]);
+ size_was_set = 1;
...here maybe only one of them is set, but...
+ if (size_was_set)
+ {
+ set_window_size (rows, cols, fd, device_name);
...here both of them are used. Looking at the body of size_was_set()
and the code that was removed from stty it's clear that -1 means don't
change, while 0 means change to 0.
--
Egmont
-------------------------------------------------------
This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND
Ug. Missed that. I don't know how but my system always worked.
Here is the new patch.
--- stty.c.orig 2004-05-07 17:48:51.000000000 -0700
+++ stty.c 2004-06-16 14:38:21.000000000 -0700
@@ -733,6 +733,10 @@
int speed_was_set;
int verbose_output;
int recoverable_output;
+#ifdef TIOCGWINSZ
+ int size_was_set = 0;
+ int cols = -1, rows = -1;
+#endif
int k;
int noargs = 1;
char *file_name = NULL;
@@ -1004,8 +1008,8 @@
usage (EXIT_FAILURE);
}
++k;
- set_window_size ((int) integer_arg (argv[k]), -1,
- fd, device_name);
+ rows = integer_arg (argv[k]);
+ size_was_set = 1;
}
else if (STREQ (argv[k], "cols")
|| STREQ (argv[k], "columns"))
@@ -1016,8 +1020,8 @@
usage (EXIT_FAILURE);
}
++k;
- set_window_size (-1, (int) integer_arg (argv[k]),
- fd, device_name);
+ cols = integer_arg (argv[k]);
+ size_was_set = 1;
}
else if (STREQ (argv[k], "size"))
{@@ -1063,6 +1067,12 @@
k++;
}
+#ifdef TIOCGWINSZ
+ if (size_was_set)
+ {
+ set_window_size (rows, cols, fd, device_name);
+ }
+#endif
if (require_set_attr)
{
struct termios new_mode;
-------------------------------------------------------This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND