[PATCH] radeonfb: 16bpp copyarea() fixed!

DORMANTno replies

From: David Eger <hidden>
Date: 2004-06-29 09:36:55

Dear Andrew,

It turns out the bug was due to my mis-copying a certain set of 
flags from the x.org tree.  The fix is as follows.  Thanks for not
accepting an ugly work around :-)  Please see that this gets to 
mainline.

-dte

radeonfb: fix 16bpp copyarea() bug

Signed-off-by: David Eger <redacted>

diff -Nru a/drivers/video/aty/radeon_accel.c b/drivers/video/aty/radeon_accel.c
--- a/drivers/video/aty/radeon_accel.c	2004-06-29 11:21:26 +02:00
+++ b/drivers/video/aty/radeon_accel.c	2004-06-29 11:21:26 +02:00
@@ -71,9 +71,10 @@
 	radeon_fifo_wait(3);
 	OUTREG(DP_GUI_MASTER_CNTL,
 		rinfo->dp_gui_master_cntl /* i.e. GMC_DST_32BPP */
+		| GMC_BRUSH_NONE
 		| GMC_SRC_DSTCOLOR
 		| ROP3_S 
-		| DP_SRC_RECT );
+		| DP_SRC_SOURCE_MEMORY );
 	OUTREG(DP_WRITE_MSK, 0xffffffff);
 	OUTREG(DP_CNTL, (xdir>=0 ? DST_X_LEFT_TO_RIGHT : 0)
 			| (ydir>=0 ? DST_Y_TOP_TO_BOTTOM : 0));


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help