# Re: \[PATCH\]\[RIVAFB\]: Updates to rivafb driver

- From: Antonino A. Daplas \<hidden\>
- Date: 2004-06-16 22:28:52 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2004/06/13453168
- Thread: https://ratatoskr.run/linux-fbdev/2004/06/13453149/t.md

```text
On Thursday 17 June 2004 01:34, David Eger wrote:
> On Wed, Jun 16, 2004 at 01:53:51PM +0800, Antonino A. Daplas wrote:
> > > On Wednesday 16 June 2004 06:17, David Eger wrote:
> > > > hey tony,
> > > >
> > > > your patch against drivers/video/riva/fbdev.c chokes on hunk 2 when
> > > > applied to 2.6.7-rc3-mm2.  resend, and i'll test it on my TNT2 :)
> > >
> > > Ok.  Patch against 2.6.7-rc3-mm2.
>
> Applying your rivafb and fbmode patches work great on my TNT2.
> I get a console with 160 columns and 60 rows :-)

That's great.

>
> And yes, the capabilities patch makes your driver slow.
> But setting the proper flags makes it fast again ;-)

Do you mind submitting a patch yourself?  It's probably a 1 liner patch, unless
we also modify rivafb to use cfb_* drawing functions depending on
the setting of var->accel_flags.

>
> The driver still doesn't play nice with the evil binary nvidia drivers,
> but then, that's expected.  (It'd be nice if changing from X to a console
> didn't *crash my machine* though.)
>

Yeah, even with XOrg/Free86 nv driver, it hangs.  Don't really know the exact
solution, probably a complete re-initialization of the hardware when switching from
X.  But this will require that fbcon recognizes a switch from X itself which it
currently doesn't (unless I'm mistaken).

Tony




-------------------------------------------------------
This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND
```