[PATCH] sbusfb: Initialize cmap.transp in FBIOPUTCMAP_SPARC

STALE8091d

2 messages, 2 authors, 2004-06-07 · open the first message on its own page

[PATCH] sbusfb: Initialize cmap.transp in FBIOPUTCMAP_SPARC

From: Adam Kropelin <hidden>
Date: 2004-06-06 05:06:29

When handling FBIOPUTCMAP_SPARC, sbusfb fails to initialize cmap.transp,
which quickly leads to an oops when fb_set_cmap() dereferences it.

First encountered in Aurora Wombat kernels and seems to afflict mainline
as well. Patch is against 2.6.7-rc2. xorg still fails to actually get
anything to display on my CG6, but at least it no longer oopses the kernel.

Signed-off-by: Adam Kropelin <redacted>
--- linux-2.6.7-rc2/drivers/video/sbuslib.c	2004-05-09 22:32:27.000000000 -0400
+++ linux-2.6.7-rc2-adk/drivers/video/sbuslib.c	2004-06-06 04:10:52.682928000 -0400
@@ -122,6 +122,7 @@
 		cmap.red = &red;
 		cmap.green = &green;
 		cmap.blue = &blue;
+		cmap.transp = NULL;
 		for (i = 0; i < count; i++) {
 			int err;
 

Re: [PATCH] sbusfb: Initialize cmap.transp in FBIOPUTCMAP_SPARC

From: David S. Miller <hidden>
Date: 2004-06-07 02:58:58

On Sun, 6 Jun 2004 01:06:29 -0400
Adam Kropelin [off-list ref] wrote:
When handling FBIOPUTCMAP_SPARC, sbusfb fails to initialize cmap.transp,
which quickly leads to an oops when fb_set_cmap() dereferences it.

First encountered in Aurora Wombat kernels and seems to afflict mainline
as well. Patch is against 2.6.7-rc2. xorg still fails to actually get
anything to display on my CG6, but at least it no longer oopses the kernel.

Signed-off-by: Adam Kropelin <redacted>
Applied, thanks a lot Adam.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help