RE: Submit Silicon Motion SM501 (VoyagerGX) display driver for li nux kernel 2.6.4

Sure, I'll CC it to linux-fbdev-devel@lists.sourceforge.net. Thanks for your
suggestion.

Ge

-----Original Message-----
From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org] 
Sent: Wednesday, March 24, 2004 3:51 PM
To: Ge Wang
Subject: Re: Submit Silicon Motion SM501 (VoyagerGX) display driver for
linux kernel 2.6.4


On Thu, 2004-03-25 at 10:20, Ge Wang wrote:

Hi Ben,

We'd like to submit Silicon Motion SM501 (VoyagerGX) display driver 
source code for linux kernel 2.6.4. I attach it with this email. It 
will be put on our web site soon. It's at(www.siliconmotion.com) 
Support\Drivers\Voyager
(SM501) Software Update\voyager-0.01-linux-2.6.4.tgz. If you have any
questions or concerns, just let me know. Your help is very appreciated.

Hi !

Can you post this to the linux-fbdev mailing list (Sorry for ping-ponging
you like this, but this is the best way to get some good review of the
driver)

Best regards,

Ge

-----Original Message-----
From: Andrew Morton [mailto:akpm@osdl.org]
Sent: Tuesday, January 06, 2004 11:19 AM
To: Ge Wang
Cc: davej@redhat.com; Alan.Cox@linux.org; GeWang@siliconmotion.com;

Benjamin

Herrenschmidt; James Simmons
Subject: Re: How to submit a kernel display driver for a new graphic hardw
are?



Thanks, Ge.  That's great.

The people to be looking at this driver are Benjamin Herrenschmidt and 
James Simmons, amongst others.

If you have a version of the driver which works under the 2.6 kernel, 
please send it along in reply to this email if you like.

Ge Wang [off-list ref] wrote:

quoted

Dear Sir,

I am a software engineer in Silicon Motion, Inc. We developed a 
kernel display driver for a graphic chip (Voyager GX)  of Silicon 
Motion, Inc. It is in linux/drivers/video directory. It was 
developed on Redhat Linux 9.0 (kernel 2.4.20-6). We'd like to submit 
it to the Linux kernel source code package. Could you let me know 
the procedure to do so?

Best regards,

Ge

-----Original Message-----
From: Alan Cox [mailto:alan@lxorguk.ukuu.org.uk]
Sent: Tuesday, December 23, 2003 1:26 PM
To: Ge Wang
Cc: Alan.Cox@linux.org
Subject: Re: How to submit a kernel display driver for a new graphic 
hardware?


On Gwe, 2003-12-19 at 23:25, Ge Wang wrote:

quoted

I am a software engineer in Silicon Motion, Inc. We developed a
kernel
display driver for a graphic chip (Voyager GX)  of Silicon Motion, 
Inc. It is in linux/drivers/video directory. We'd like to submit it to

quoted

quoted

the Linux kernel source code package. Could you let me know the 
procedure to do so? Or let me know who should I contact to?

For the development kernel I am not sure of the current status. The
2.6.0 kernel didnt include the final frame buffer changes as they were 
delayed. Andrew Morton [off-list ref] can probably advise on that. 
For Red Hat consideration I would send a copy to Dave Jones 
[off-list ref].

Marcelo Tosatti [off-list ref] deals with the 2.4
kernel tree although he now has a policy of "2.6 first". Given the 2.6 
confusion perhaps it may be considered for 2.4 - I don't know.

I'm away at University until June otherwise I'd be delighted to help
directly.

Thank you to you and your company for contributing to Linux

Alan

-- 
Benjamin Herrenschmidt [off-list ref]

To follow up on this (as no one else seems to have), this current driver has
a number of issues. A big part of necessary cleanup could be done just with
doing away with the hungarian notation nonsense, using standard types, and
using a struct fb_videomode modedb instead if wrapping everything to use the
non-standard modedb that exists in the driver currently.

Additionally, I have a board I'm working on presently that has an SM501 on it
(non-PCI) which this driver presently won't work on. Furthermore, I have
another set of SM501 fb drivers from Renesas that break things out somewhat
further (which includes i2c, once I finish hacking on the voyager i2c stuff).
This actually breaks it out into 7 different framebuffers:

#ifdef CONFIG_FB_VOYAGER_GX
        { "voyager_panel_fb", voyafb_init, NULL },
        { "voyager_video_fb", voyafb_init2, NULL },
        { "voyager_valpha_fb", voyafb_init3, NULL },
        { "voyager_alpha_fb", voyafb_init4, NULL },
        { "voyager_panel_csr_fb", voyafb_init5, NULL },
        { "voyager_crt_fb", voyafb_init6, NULL },
        { "voyager_crt_csr_fb", voyafb_init7, NULL },
#endif

As such, this needs some rework as well. The default voyager_panel_fb should
be pretty close to what Ge's driver does, though presently doesn't address PCI.
I plan on merging in Ge's driver at the same time I do the rework on the
Renesas one (though Ge and others will have to do testing on PCI).

I'd appreciate it if no one merged any SM501 related fb patches until I'm
finished consolidating the various implementations and we have something in
place that will work for everyone.

On Wed, Mar 24, 2004 at 04:10:11PM -0800, Ge Wang wrote:

Sure, I'll CC it to linux-fbdev-devel@lists.sourceforge.net. Thanks for your
suggestion.

Ge

-----Original Message-----
From: Benjamin Herrenschmidt [mailto:benh@kernel.crashing.org] 
Sent: Wednesday, March 24, 2004 3:51 PM
To: Ge Wang
Subject: Re: Submit Silicon Motion SM501 (VoyagerGX) display driver for
linux kernel 2.6.4


On Thu, 2004-03-25 at 10:20, Ge Wang wrote:

quoted

Hi Ben,

We'd like to submit Silicon Motion SM501 (VoyagerGX) display driver 
source code for linux kernel 2.6.4. I attach it with this email. It 
will be put on our web site soon. It's at(www.siliconmotion.com) 
Support\Drivers\Voyager
(SM501) Software Update\voyager-0.01-linux-2.6.4.tgz. If you have any
questions or concerns, just let me know. Your help is very appreciated.

Hi !

Can you post this to the linux-fbdev mailing list (Sorry for ping-ponging
you like this, but this is the best way to get some good review of the
driver)