# Re: New FBDev patch

- From: James Simmons \<hidden\>
- Date: 2004-01-09 19:54:56 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2004/01/606660
- Thread: https://ratatoskr.run/lkml/2004/01/606430/t.md

```text

> > This is the latest patch against 2.6.0-rc3. Give it a try.
> > 
> > http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz
> 
> This looks wrong (cyber2000fb.c):

Yeap it is. Typo. 

> sizeof(u32) != 32.  Proper fix is to place the pseudopalette array
> inside cfb_info, and dispense with this addition here.

You have to make sure the struct fb_info pseudopalette points to the data 
in cfb_info. Actually only drivers should allocate the pseudopalette at 
boot time if the hardware doesn't support mode change. In the other case 
the pseudopalette should be allocated in set_par. 




-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html
```