Re: New FBDev patch

On Thu, Jan 08, 2004 at 10:03:54PM +0000, James Simmons wrote:

This is the latest patch against 2.6.0-rc3. Give it a try.

http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz

This looks wrong (cyber2000fb.c):

@@ -1220,18 +1220,18 @@
 }

 static struct cfb_info * __devinit
-cyberpro_alloc_fb_info(unsigned int id, char *name)
+cyberpro_alloc_fb_info(unsigned int id, char *name, struct device *dev)
 {
        struct cfb_info *cfb;
+       struct fb_info *fb_info;

-       cfb = kmalloc(sizeof(struct cfb_info) +
-                      sizeof(u32) * 16, GFP_KERNEL);
+       fb_info = framebuffer_alloc(sizeof(struct cfb_info) + 32 * 16, dev);

sizeof(u32) != 32.  Proper fix is to place the pseudopalette array
inside cfb_info, and dispense with this addition here.

I could supply a patch, but I'll wait for this to be merged before
I fix this up.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core


-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html

quoted

This is the latest patch against 2.6.0-rc3. Give it a try.

http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz

This looks wrong (cyber2000fb.c):

Yeap it is. Typo. 

sizeof(u32) != 32.  Proper fix is to place the pseudopalette array
inside cfb_info, and dispense with this addition here.

You have to make sure the struct fb_info pseudopalette points to the data 
in cfb_info. Actually only drivers should allocate the pseudopalette at 
boot time if the hardware doesn't support mode change. In the other case 
the pseudopalette should be allocated in set_par. 




-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html