tgafb broken in 2.6test9 compile

Hi.

I'm trying to compile 2.6.0test9 and ran into the following error:

make[1]: `arch/alpha/kernel/asm-offsets.s' is up to date.
  CHK     include/linux/compile.h
    CC      drivers/video/tgafb.o
    drivers/video/tgafb.c:83: `tgafb_pci_unregister' undeclared here
    (not in a function)
    drivers/video/tgafb.c:83: initializer element is not constant
    drivers/video/tgafb.c:83: (near initialization for
    `tgafb_driver.remove')
    drivers/video/tgafb.c:84: initializer element is not constant
    drivers/video/tgafb.c:84: (near initialization for `tgafb_driver')
    drivers/video/tgafb.c: In function `tgafb_set_par':
    drivers/video/tgafb.c:233: `color_table' undeclared (first use in
    this function)
    drivers/video/tgafb.c:233: (Each undeclared identifier is reported
    only once
    drivers/video/tgafb.c:233: for each function it appears in.)
    drivers/video/tgafb.c:234: `default_red' undeclared (first use in
    this function)
    drivers/video/tgafb.c:236: `default_grn' undeclared (first use in
    this function)
    drivers/video/tgafb.c:238: `default_blu' undeclared (first use in
    this function)
    make[2]: *** [drivers/video/tgafb.o] Error 1
    make[1]: *** [drivers/video] Error 2
    make: *** [drivers] Error 2
    


I tried adding #include <linux/selection.h> as pointed out at the
following URL

http://www.ussg.iu.edu/hypermail/linux/kernel/0309.2/0027.html

but then got this:

make[1]: `arch/alpha/kernel/asm-offsets.s' is up to date.
  CHK     include/linux/compile.h
    CC      drivers/video/tgafb.o
    drivers/video/tgafb.c:84: `tgafb_pci_unregister' undeclared here
    (not in a function)
    drivers/video/tgafb.c:84: initializer element is not constant
    drivers/video/tgafb.c:84: (near initialization for
    `tgafb_driver.remove')
    drivers/video/tgafb.c:85: initializer element is not constant
    drivers/video/tgafb.c:85: (near initialization for `tgafb_driver')
    make[2]: *** [drivers/video/tgafb.o] Error 1
    make[1]: *** [drivers/video] Error 2
    make: *** [drivers] Error 2
    
-- 
Dan Field [off-list ref]

http://www.nuclear-dawn.com/ - Drunk on the Lawn in a Nuclear Dawn


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

On Sun, 23 Nov 2003, Dan Field wrote:

I'm trying to compile 2.6.0test9 and ran into the following error:

make[1]: `arch/alpha/kernel/asm-offsets.s' is up to date.
  CHK     include/linux/compile.h
    CC      drivers/video/tgafb.o
    drivers/video/tgafb.c:83: `tgafb_pci_unregister' undeclared here
    (not in a function)
    drivers/video/tgafb.c:83: initializer element is not constant
    drivers/video/tgafb.c:83: (near initialization for
    `tgafb_driver.remove')
    drivers/video/tgafb.c:84: initializer element is not constant
    drivers/video/tgafb.c:84: (near initialization for `tgafb_driver')
    drivers/video/tgafb.c: In function `tgafb_set_par':
    drivers/video/tgafb.c:233: `color_table' undeclared (first use in
    this function)
    drivers/video/tgafb.c:233: (Each undeclared identifier is reported
    only once
    drivers/video/tgafb.c:233: for each function it appears in.)
    drivers/video/tgafb.c:234: `default_red' undeclared (first use in
    this function)
    drivers/video/tgafb.c:236: `default_grn' undeclared (first use in
    this function)
    drivers/video/tgafb.c:238: `default_blu' undeclared (first use in
    this function)
    make[2]: *** [drivers/video/tgafb.o] Error 1
    make[1]: *** [drivers/video] Error 2
    make: *** [drivers] Error 2

Tgafb wasn't converted to the new fbdev frame work yet. It should be fixed in
James Simmons' tree:

    http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz
    bk://fbdev.bkbits.net/fbdev-2.5

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/