[PATCH] Leak in vesafb

STALE8354d

2 messages, 1 author, 2003-10-06 · open the first message on its own page

[PATCH] Leak in vesafb

From: Felipe W Damasio <hidden>
Date: 2003-10-06 21:26:55 

	Hi Andrew,

	Patch against 2.6.0-test6.

	Releases a previous request'ed_mem_region. Found by smatch.

	Since it didn't checked the return value of request_region, I'm not 
sure we should free it here...since (as it says on the driver), 
"vgacon probably has this region already".

	Andrew, I'd appreciate you could review this..

	Thanks.

Felipe

Re: [PATCH] Leak in vesafb

From: Felipe W Damasio <hidden>
Date: 2003-10-06 21:35:14 


Felipe W Damasio wrote:
    Hi Andrew,

    Patch against 2.6.0-test6.

    Releases a previous request'ed_mem_region. Found by smatch.

    Since it didn't checked the return value of request_region, I'm not 
sure we should free it here...since (as it says on the driver), "vgacon 
probably has this region already".

    Andrew, I'd appreciate you could review this..
	Also, this updated patch also iounmap fb_info.screen_base, since 
we're about to return -EINVAL on vesa_init.

	Cheers,

Felipe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help