# Re: Re: New radeonfb, mostly untested

- From: Geert Uytterhoeven \<geert@linux-m68k.org\>
- Date: 2003-09-11 06:05:25 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2003/09/13451737
- Thread: https://ratatoskr.run/linux-fbdev/2003/09/13451686/t.md

```text
On Wed, 10 Sep 2003, Benjamin Herrenschmidt wrote:
> > It  fails only  if  compiled  as module. I  see  that fb_find_mode  (and
> > my_atoi) are marked  as __init. Maybe they get discarded  after boot and
> > when  radeonfb module  tries  to call  them it  ends  up in  deallocated
> > memory...
> 
> Exactly, they should definitely not be marked __init

That doesn't harm. If MODULE is defined, fb_find_mode() is an inline function
that knows about 640x400@70 only, cfr. <linux/fb.h>.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
```