fbdev and power management

I'm trying to get the radeon M6 in my new Fujitsu Lifebook to handle
ACPI S3 suspend and resume properly - at the moment, on resume it
fails to do anything. Looking at the driver, the reason is quite
obvious (no .suspend and .resume functions defined), but the driver
file has code to handle these (apparently only for the PowerBooks,
since it's wrapped in a #ifdef CONIG_PMAC_PBOOK). My Lifebook P2120
is a Crusoe 5800 based setup, with a PCI M6, so it's not even being
built, let alone enabled and used. 

As far as I can tell, if I removed the #ifdef CONFIG_PMAC_PBOOK and
split the current radeon_set_suspend up into suspend and resume
functions to fit the current power management stuff, it might have
some chance of working. Can you tell me if this is a reasonable
first step?

Alternatively, if you have patches that I could test, I'd be quite
happy to give them a go - being a guinea pig sounds like fun ;-)

No patches at this time. I need to learn the new power management code. 
Where are the docs for them ? 




-------------------------------------------------------
This SF.Net email sponsored by: Parasoft
Error proof Web apps, automate testing & more.
Download & eval WebKing and get a free book.
www.parasoft.com/bulletproofapps

No patches at this time. I need to learn the new power management code. 
Where are the docs for them ? 

The PM code in radeonfb is probably only useful for Mac laptops where
we have to manually put the chip in D2 state. I don't think x86 laptops
use D2...

Note that I have a patch adding some basic PM support to fbdev in 2.5
that I need to send you for review. The PM is always initiated by the
low level driver which gets notified of PM events by its parent bus,
what I added is a way for the driver to "broadcast" that to clients
like fbcon so fbcon can stop touching the framebuffer while the chip
is potentially off, and can restore the display on wakeup.

I'll send that to you asap. 

Note: The Power Management isn't well implemented in 2.5 yet. The
infrastructure is mostly there, but the driver side semantics are
still wrong. Patrick Mochel has a new implementation that is much
better, but he didn't merge it upstream yet. I expect this will
happen around Kernel Summit / OLS.

Ben.



-------------------------------------------------------
This SF.Net email sponsored by: Parasoft
Error proof Web apps, automate testing & more.
Download & eval WebKing and get a free book.
www.parasoft.com/bulletproofapps