# Re: rivafb "Badness" using fbdev.diff.gz and 2.5.5\[45\]

- From: Antonino Daplas \<hidden\>
- Date: 2003-01-30 23:14:38 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2003/01/13450883
- Thread: https://ratatoskr.run/linux-fbdev/2003/01/13450764/t.md

```text
On Sat, 2003-01-25 at 04:14, James Simmons wrote:
> 
> I applied part of the patch. I like to avoid changing nv_driver to much 
> because it is based on the X windows driver. Easier to keep them sync. 
> What we could do is move the following 
> 
> riva_common_setup(par);
> ..
> 
> par->dclk_max = par->riva.MaxVClock..
> 
> from rivafb_probe to riavfb_open. Can you give tht a try and tell me if it 
> works.
> 

I haven't tried this yet, but I think it will work.  The only (very
minor) problem with this is the rivafb's printk output will be incorrect
(no info on video memory size).  

Tony



-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
```