Re: [BK PATCHS] fbdev updates.

On Fri, Oct 18, 2002 at 10:27:59AM -0700, James Simmons wrote:

Yes the drivers should always have priority. The other stuff is there
only if the drivers have no power management of any kind. I leave it up to
the driver write to implement a fb_blank function that handles different
cases.

The drivers don't have priority though.  You call set_par, and then
wander off into the internals of fbgen.c to set can_soft_blank youself,
without giving the drivers any look-in to set that correctly.

quoted

There is also the argument about wanting soft blanking, but hardware power
saving.

Hm. True unfortunely the fbdev layer lacks handling details like that. The
console system is even worse. This is why a single flag like
can_soft_blank can actually be a limitation.

Well, it needs to be fixed.  We've lost functionality that was present in
2.4, and therefore I call it a bug.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

quoted

Yes the drivers should always have priority. The other stuff is there
only if the drivers have no power management of any kind. I leave it up to
the driver write to implement a fb_blank function that handles different
cases.

The drivers don't have priority though.  You call set_par, and then
wander off into the internals of fbgen.c to set can_soft_blank youself,
without giving the drivers any look-in to set that correctly.

Your right. That is a bug from the old fbgen code. Since few driver used
the old fbgen code it never appeared. I suggest we remove can_soft_blank
and just test to see if the function pointer exist for fb_blank. If it
doesn't then we can resort to other tricks in suggested in the ther email.




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf