Oops in fbcon_setup

2 messages, 2 authors, 2002-09-01 · open the first message on its own page

Oops in fbcon_setup

From: Richard Zidlicky <hidden>
Date: 2002-08-31 20:44:58

Hi,

I came around testing q40fb.c, fbcon_setup oopses because
apparently dispsw isn't set anywhere.

This patch seems to fix it although I had very little opportunity 
to test much further (it was good enough to display the next Oops
though ;)
--- linux-m68k-2.5.x/drivers/video/q40fb.c      Tue Aug 13 21:30:36 2002
+++ build-2.5/drivers/video/q40fb.c     Sat Aug 31 14:33:11 2002
@@ -29,6 +29,7 @@
 #include <asm/pgtable.h>
 
 #include <video/fbcon.h>
+#include <video/fbcon-cfb16.h>
 
 #define Q40_PHYS_SCREEN_ADDR 0xFE800000
 
@@ -125,6 +126,8 @@
        fb_info.switch_con      = gen_switch;
        fb_info.updatevar       = gen_update_var;
        fb_alloc_cmap(&fb_info.cmap, 16, 0);
+
+       display.dispsw = &fbcon_cfb16;
 
         gen_set_disp(-1, &fb_info);
 
Richard


-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old
cell phone?  Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390

Re: Oops in fbcon_setup

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2002-09-01 09:25:49

On Sat, 31 Aug 2002, Richard Zidlicky wrote:
quoted hunk
I came around testing q40fb.c, fbcon_setup oopses because
apparently dispsw isn't set anywhere.

This patch seems to fix it although I had very little opportunity 
to test much further (it was good enough to display the next Oops
though ;)
--- linux-m68k-2.5.x/drivers/video/q40fb.c      Tue Aug 13 21:30:36 2002
+++ build-2.5/drivers/video/q40fb.c     Sat Aug 31 14:33:11 2002
@@ -29,6 +29,7 @@
 #include <asm/pgtable.h>
 
 #include <video/fbcon.h>
+#include <video/fbcon-cfb16.h>
 
 #define Q40_PHYS_SCREEN_ADDR 0xFE800000
 
@@ -125,6 +126,8 @@
        fb_info.switch_con      = gen_switch;
        fb_info.updatevar       = gen_update_var;
        fb_alloc_cmap(&fb_info.cmap, 16, 0);
+
+       display.dispsw = &fbcon_cfb16;
 
         gen_set_disp(-1, &fb_info);
Since fbcon_cfb16 is going to go away, what about using fbcon_accel and
cfb{copyarea,fillrect,imgblt}.c instead?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds



-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old
cell phone?  Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help