Bug in fbcon.c penguin drawing

2 messages, 2 authors, 2002-06-01 · open the first message on its own page

Bug in fbcon.c penguin drawing

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2002-06-01 13:31:38

By accident I stumbled on this...
Since `src' is the penguin logo, we must not use fb_read() to access it.
--- linux-2.4.19-pre9/drivers/video/fbcon.c.orig	Fri Feb 22 16:28:32 2002
+++ linux-2.4.19-pre9/fbcon.c	Sat Jun  1 15:27:31 2002
@@ -2417,7 +2417,7 @@
 		else
 		    dst = fb + y1*line + x/8;
 		for( x1 = 0; x1 < LOGO_LINE; ++x1 )
-		    fb_writeb(fb_readb(src++) ^ inverse, dst++);
+		    fb_writeb(*src++ ^ inverse, dst++);
 	    }
 	    done = 1;
 	}
--- linux-2.5.19/drivers/video/fbcon.c.orig	Mon Apr 29 09:50:07 2002
+++ linux-2.5.19/fbcon.c	Sat Jun  1 15:27:40 2002
@@ -2401,7 +2401,7 @@
 		else
 		    dst = fb + y1*line + x/8;
 		for( x1 = 0; x1 < LOGO_LINE; ++x1 )
-		    fb_writeb(fb_readb(src++) ^ inverse, dst++);
+		    fb_writeb(*src++ ^ inverse, dst++);
 	    }
 	    done = 1;
 	}
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


_______________________________________________________________

Don't miss the 2002 Sprint PCS Application Developer's Conference
August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm

Re: Bug in fbcon.c penguin drawing

From: James Simmons <hidden>
Date: 2002-06-01 17:58:52

Fixed. I added to the BK repository and will be sending Linus stuff soon.

   . ---
   |o_o |
   |:_/ |   Give Micro$oft the Bird!!!!
  //   \ \  Use Linux!!!!
 (|     | )
 /'\_   _/`\
 \___)=(___/

On Sat, 1 Jun 2002, Geert Uytterhoeven wrote:
quoted hunk
By accident I stumbled on this...
Since `src' is the penguin logo, we must not use fb_read() to access it.
--- linux-2.4.19-pre9/drivers/video/fbcon.c.orig	Fri Feb 22 16:28:32 2002
+++ linux-2.4.19-pre9/fbcon.c	Sat Jun  1 15:27:31 2002
@@ -2417,7 +2417,7 @@
 		else
 		    dst = fb + y1*line + x/8;
 		for( x1 = 0; x1 < LOGO_LINE; ++x1 )
-		    fb_writeb(fb_readb(src++) ^ inverse, dst++);
+		    fb_writeb(*src++ ^ inverse, dst++);
 	    }
 	    done = 1;
 	}
--- linux-2.5.19/drivers/video/fbcon.c.orig	Mon Apr 29 09:50:07 2002
+++ linux-2.5.19/fbcon.c	Sat Jun  1 15:27:40 2002
@@ -2401,7 +2401,7 @@
 		else
 		    dst = fb + y1*line + x/8;
 		for( x1 = 0; x1 < LOGO_LINE; ++x1 )
-		    fb_writeb(fb_readb(src++) ^ inverse, dst++);
+		    fb_writeb(*src++ ^ inverse, dst++);
 	    }
 	    done = 1;
 	}
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


_______________________________________________________________

Don't miss the 2002 Sprint PCS Application Developer's Conference
August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm

_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

_______________________________________________________________

Don't miss the 2002 Sprint PCS Application Developer's Conference
August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help