# Re: \[PATCH v6 05/13\] drm/amdkfd: generic type as sys mem on migration to ram

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2021-08-15 15:38:29 
- List: linux-ext4
- Page: https://ratatoskr.run/linux-ext4/2021/08/6510326
- Thread: https://ratatoskr.run/linux-mm/2021/08/6510276/t.md

```text
On Fri, Aug 13, 2021 at 01:31:42AM -0500, Alex Sierra wrote:
>  	migrate.vma = vma;
>  	migrate.start = start;
>  	migrate.end = end;
> -	migrate.flags = MIGRATE_VMA_SELECT_DEVICE_PRIVATE;
>  	migrate.pgmap_owner = SVM_ADEV_PGMAP_OWNER(adev);
>  
> +	if (adev->gmc.xgmi.connected_to_cpu)
> +		migrate.flags = MIGRATE_VMA_SELECT_SYSTEM;
> +	else
> +		migrate.flags = MIGRATE_VMA_SELECT_DEVICE_PRIVATE;

It's been a while since I touched this migrate code, but doesn't this
mean that if the range already contains system memory the migration
now won't do anything? for the connected_to_cpu case?
```
