[PATCH] mke2fs: warn that bigalloc is experimental only for large cluster sizes
From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-08-14 14:40:52
Subsystem:
the rest · Maintainer:
Linus Torvalds
Since we have done a lot of testing with a cluster size equal to 64k (or 16 times the default 4k block size), mke2fs will only warn for bigalloc file systems where the cluster size is greater than 16 times the block size. Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- misc/mke2fs.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index a4573972..effe963c 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c@@ -2526,11 +2526,12 @@ profile_error: exit(1); } - if (!quiet && ext2fs_has_feature_bigalloc(&fs_param)) - fprintf(stderr, "%s", _("\nWarning: the bigalloc feature is " - "still under development\n" - "See https://ext4.wiki.kernel.org/" - "index.php/Bigalloc for more information\n\n")); + if (!quiet && ext2fs_has_feature_bigalloc(&fs_param) && + EXT2_CLUSTER_SIZE(&fs_param) > 16 * EXT2_BLOCK_SIZE(&fs_param)) + fprintf(stderr, "%s", _("\nWarning: bigalloc file systems " + "with a cluster size greater than\n" + "16 times the block size is considered " + "experimental\n")); /* * Since sparse_super is the default, we would only have a problem
--
2.31.0