Re: [PATCH v3 14/15] samples: Add fs error monitoring example

"Chen, Rong A" [off-list ref] writes:

Hi Gabriel,

On 7/21/2021 3:49 AM, Dan Carpenter wrote:

quoted

On Mon, Jul 19, 2021 at 10:36:54AM -0400, Gabriel Krisman Bertazi
wrote:

quoted

kernel test robot [off-list ref] writes:

quoted

Hi Gabriel,

I love your patch! Yet something to improve:

[auto build test ERROR on ext3/fsnotify]
[also build test ERROR on ext4/dev linus/master v5.13 next-20210629]
[cannot apply to tytso-fscrypt/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch ]

url:    https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210630-031347
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git  fsnotify
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross  -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         # https://github.com/0day-ci/linux/commit/746524d8db08a041fed90e41b15c8e8ca69cb22d
         git remote add linux-review https://github.com/0day-ci/linux
         git fetch --no-tags linux-review Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210630-031347
         git checkout 746524d8db08a041fed90e41b15c8e8ca69cb22d
         # save the attached .config to linux build tree
         mkdir build_dir
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash samples/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

quoted

quoted

samples/fanotify/fs-monitor.c:7:10: fatal error: errno.h: No such file or directory

        7 | #include <errno.h>
          |          ^~~~~~~~~
    compilation terminated.

Hi Dan,

I'm not sure what's the proper fix here.  Looks like 0day is not using
cross system libraries when building this user space code.  Should I do
something special to silent it?

It seems need extra libraries for arm64, we'll disable CONFIG_SAMPLES to
avoid reporting this error.

There are kernel space code in samples/ that still benefit from the test
robot. See ftrace/ftrace-direct-too.c for one instance.

Perhaps it can be disabled just for userprogs-* Makefile entries in
samples/ ?

-- 
Gabriel Krisman Bertazi

On 7/23/2021 12:15 AM, Gabriel Krisman Bertazi wrote:

"Chen, Rong A" [off-list ref] writes:

quoted

Hi Gabriel,

On 7/21/2021 3:49 AM, Dan Carpenter wrote:

quoted

On Mon, Jul 19, 2021 at 10:36:54AM -0400, Gabriel Krisman Bertazi
wrote:

quoted

kernel test robot [off-list ref] writes:

quoted

Hi Gabriel,

I love your patch! Yet something to improve:

[auto build test ERROR on ext3/fsnotify]
[also build test ERROR on ext4/dev linus/master v5.13 next-20210629]
[cannot apply to tytso-fscrypt/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch ]

url:    https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210630-031347
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git  fsnotify
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross  -O ~/bin/make.cross
          chmod +x ~/bin/make.cross
          # https://github.com/0day-ci/linux/commit/746524d8db08a041fed90e41b15c8e8ca69cb22d
          git remote add linux-review https://github.com/0day-ci/linux
          git fetch --no-tags linux-review Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210630-031347
          git checkout 746524d8db08a041fed90e41b15c8e8ca69cb22d
          # save the attached .config to linux build tree
          mkdir build_dir
          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash samples/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

quoted

quoted

samples/fanotify/fs-monitor.c:7:10: fatal error: errno.h: No such file or directory

         7 | #include <errno.h>
           |          ^~~~~~~~~
     compilation terminated.

Hi Dan,

I'm not sure what's the proper fix here.  Looks like 0day is not using
cross system libraries when building this user space code.  Should I do
something special to silent it?

It seems need extra libraries for arm64, we'll disable CONFIG_SAMPLES to
avoid reporting this error.

There are kernel space code in samples/ that still benefit from the test
robot. See ftrace/ftrace-direct-too.c for one instance.

Perhaps it can be disabled just for userprogs-* Makefile entries in
samples/ ?

we'll still test samples on arch x86_64, is there a simple way to 
disable userprogs-* cases? we don't want to edit kernel code.

Best Regards,
Rong Chen