# Re: \[PATCH v3 07/15\] fsnotify: pass arguments of fsnotify() in struct fsnotify\_event\_info

- From: Amir Goldstein \<amir73il@gmail.com\>
- Date: 2021-06-30 09:32:39 
- List: linux-ext4
- Page: https://ratatoskr.run/linux-ext4/2021/06/208996
- Thread: https://ratatoskr.run/linux-fsdevel/2021/06/208949/t.md

```text
On Wed, Jun 30, 2021 at 11:46 AM Dan Carpenter [ref] wrote:
>
> On Wed, Jun 30, 2021 at 11:35:32AM +0300, Amir Goldstein wrote:
> >
> > Do you have feeling of dejavu? ;-)
> > https://lore.kernel.org/linux-fsdevel/20200730192537.GB13525@quack2.suse.cz/
>
> That was a year ago.  I have trouble remembering emails I sent
> yesterday.
>
> >
> > We've been through this.
> > Maybe you silenced the smach warning on fsnotify() and the rename to
> > __fsnotifty()
> > caused this warning to refloat?
>
> Yes.  Renaming the function will make it show up as a new warning.  Also
> this is an email from the kbuild-bot and last years email was from me,
> so it's a different tool and a different record of sent messages.
>
> (IMO, you should really just remove the bogus NULL checks because
> everyone looking at the warning will think the code is buggy).
>

I think the warning is really incorrect.
Why does it presume that event_info->dir is non-NULL?
Did smach check all the callers to fsnotify() or something?
What about future callers that will pass NULL, just like this one:

https://lore.kernel.org/linux-fsdevel/20210629191035.681913-12-krisman@collabora.com/

Please fix the tool.

Thanks,
Amir.
```