[PATCH] ext4: Correct encrypted_casefold sysfs entry

Subsystems: ext4 file system, filesystems (vfs and infrastructure), the rest

STALE1965d

2 messages, 2 authors, 2021-06-02 · open the first message on its own page

[PATCH] ext4: Correct encrypted_casefold sysfs entry

From: Daniel Rosenberg <hidden>
Date: 2021-06-02 04:01:42

Encrypted casefolding is only supported when both encryption and
casefolding are both enabled in the config.

Signed-off-by: Daniel Rosenberg <redacted>
---
 fs/ext4/sysfs.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/fs/ext4/sysfs.c b/fs/ext4/sysfs.c
index 6f825dedc3d4..55fcab60a59a 100644
--- a/fs/ext4/sysfs.c
+++ b/fs/ext4/sysfs.c
@@ -315,7 +315,9 @@ EXT4_ATTR_FEATURE(verity);
 #endif
 EXT4_ATTR_FEATURE(metadata_csum_seed);
 EXT4_ATTR_FEATURE(fast_commit);
+#if defined(CONFIG_UNICODE) && defined(CONFIG_FS_ENCRYPTION)
 EXT4_ATTR_FEATURE(encrypted_casefold);
+#endif
 
 static struct attribute *ext4_feat_attrs[] = {
 	ATTR_LIST(lazy_itable_init),
@@ -333,7 +335,9 @@ static struct attribute *ext4_feat_attrs[] = {
 #endif
 	ATTR_LIST(metadata_csum_seed),
 	ATTR_LIST(fast_commit),
+#if defined(CONFIG_UNICODE) && defined(CONFIG_FS_ENCRYPTION)
 	ATTR_LIST(encrypted_casefold),
+#endif
 	NULL,
 };
 ATTRIBUTE_GROUPS(ext4_feat);
-- 
2.32.0.rc0.204.g9fa02ecfa5-goog

Re: [PATCH] ext4: Correct encrypted_casefold sysfs entry

From: Eric Biggers <ebiggers@kernel.org>
Date: 2021-06-02 19:48:11

On Wed, Jun 02, 2021 at 04:01:00AM +0000, Daniel Rosenberg wrote:
Encrypted casefolding is only supported when both encryption and
casefolding are both enabled in the config.

Signed-off-by: Daniel Rosenberg <redacted>
Looks good, but please include Fixes and Cc stable tags.

- Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help