Re: [PATCH 3/4] fscrypt: move non-public structures and constants to fscrypt_private.h
From: Eric Biggers <hidden>
Date: 2016-11-29 21:07:02
Also in:
linux-fsdevel
From: Eric Biggers <hidden>
Date: 2016-11-29 21:07:02
Also in:
linux-fsdevel
On Sat, Nov 26, 2016 at 11:41:54PM -0500, Theodore Ts'o wrote:
Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- fs/crypto/crypto.c | 2 +- fs/crypto/fscrypt_private.h | 71 +++++++++++++++++++++++++++++++++++++++++++++ fs/crypto/policy.c | 2 +- include/linux/fscrypto.h | 68 ++----------------------------------------- 4 files changed, 76 insertions(+), 67 deletions(-)
This looks good to me. There are however a few other things I think would belong in the private header too, like the #includes of <linux/key.h> and <crypto/skcipher.h>, the declaration of 'fscrypt_info_cachep', and some of the inline functions. Reviewed-by: Eric Biggers <redacted>