# Re: \[PATCH 02/35\] block: add REQ\_OP definitions and bi\_op/op fields

- From: Martin K. Petersen \<hidden\>
- Date: 2016-01-06 23:17:01 
- List: linux-ext4
- Page: https://ratatoskr.run/linux-ext4/2016/01/103541
- Thread: https://ratatoskr.run/linux-f2fs-devel/2016/01/103541/t.md

```text
>>>>> "Mike" == mchristi  [ref] writes:

+enum req_op {
+	REQ_OP_READ,
+	REQ_OP_WRITE		= REQ_WRITE,
+	REQ_OP_DISCARD		= REQ_DISCARD,
+	REQ_OP_WRITE_SAME	= REQ_WRITE_SAME,
+};
+

I have been irked by the REQ_ prefix in bios since the flags were
consolidated a while back. When I attempted to fix the READ/WRITE mess I
used a BLK_ prefix as a result.

Anyway. Just bikeshedding...

-- 
Martin K. Petersen	Oracle Linux Engineering
```
