# Re: \[PATCH 1/2\] ext4: replace ext4\_io\_submit-\>io\_op with -\>io\_wbc

- From: Theodore Ts'o \<hidden\>
- Date: 2015-07-22 03:56:09 
- List: linux-ext4
- Page: https://ratatoskr.run/linux-ext4/2015/07/97842
- Thread: https://ratatoskr.run/cgroups/2015/07/97842/t.md

```text
On Tue, Jun 16, 2015 at 06:53:12PM -0400, Tejun Heo wrote:
> ext4_io_submit_init() takes the pointer to writeback_control to test
> its sync_mode and determine between WRITE and WRITE_SYNC and records
> the result in ->io_op.  This patch makes it record the pointer
> directly and moves the test to ext4_io_submit().
> 
> This doesn't cause any noticeable differences now but having
> writeback_control available throughout IO submission path will be
> depended upon by the planned cgroup writeback support.
> 
> Signed-off-by: Tejun Heo <redacted>
> Cc: "Theodore Ts'o" <redacted>
> Cc: Andreas Dilger <redacted>
> Cc: <redacted>

Thanks, applied.

						- Ted
```