# Re: \[PATCH 3/9\] xfs: factor out everything but the filemap\_write\_and\_wait from xfs\_file\_fsync

- From: Jeff Moyer \<hidden\>
- Date: 2012-11-21 14:10:35 
- List: linux-ext4
- Page: https://ratatoskr.run/linux-ext4/2012/11/69063
- Thread: https://ratatoskr.run/linux-fsdevel/2012/11/69063/t.md

```text
Christoph Hellwig [ref] writes:

> On Mon, Nov 19, 2012 at 11:41:38PM -0800, Darrick J. Wong wrote:
>> Hi,
>> 
>> Fsyncing is tricky business, so factor out the bits of the xfs_file_fsync
>> function that can be used from the I/O post-processing path.
>
> Why would we need to skip the filemap_write_and_wait_range call here?
> If we're doing direct I/O we should not have any pages in this regions
> anyway.  You're also not skipping it in the generic implementation as
> far as I can see, so I see no point in doing it just in XFS.

OK, I'll fix that.

Thanks!
Jeff
```