DORMANTno replies

[PATCH] ext4: remove an unneeded check in ext4_releasepage

From: Andrew Perepechko <hidden>
Date: 2012-07-02 18:25:10
Subsystem: ext4 file system, filesystems (vfs and infrastructure), the rest · Maintainers: "Theodore Ts'o", Alexander Viro, Christian Brauner, Linus Torvalds

From: Andrew Perepechko <redacted>

The page_has_buffers() checks in ext3/4_releasepage are not
needed, since ->releasepage() is only called if
page_has_private() is positive.

Signed-off-by: Andrew Perepechko <redacted>
---
 fs/ext3/inode.c |    2 --
 fs/ext4/inode.c |    2 --
 2 files changed, 4 deletions(-)
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 9a4a5c4..ee5ef30 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1841,8 +1841,6 @@ static int ext3_releasepage(struct page *page, gfp_t wait)
 
 	trace_ext3_releasepage(page);
 	WARN_ON(PageChecked(page));
-	if (!page_has_buffers(page))
-		return 0;
 	return journal_try_to_free_buffers(journal, page, wait);
 }
 
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 02bc8cb..bfad0a8 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2796,8 +2796,6 @@ static int ext4_releasepage(struct page *page, gfp_t wait)
 	trace_ext4_releasepage(page);
 
 	WARN_ON(PageChecked(page));
-	if (!page_has_buffers(page))
-		return 0;
 	if (journal)
 		return jbd2_journal_try_to_free_buffers(journal, page, wait);
 	else
-- 
1.7.9.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help