Re: [PATCH] ext4: do not enable delalloc by default for ext2
From: Eric Sandeen <hidden>
Date: 2012-03-27 15:34:41
On 3/27/12 8:46 AM, Brian Foster wrote:
Use traditional ext2 mount options. Do not enable delalloc by default for ext2.
This makes sense to me, I think. It was done for ext3 to semi-preserve the journal "5s sync" I think, and one could argue that delalloc is ok for ext2, but it seems like people would expect behavior which is as close to what ext2.ko provided as possible. So, Reviewed-by: Eric Sandeen <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Brian Foster <redacted> --- fs/ext4/super.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 9339009..b08a547 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c@@ -3229,7 +3229,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) * enable delayed allocation by default * Use -o nodelalloc to turn it off */ - if (!IS_EXT3_SB(sb) && + if (!IS_EXT3_SB(sb) && !IS_EXT2_SB(sb) && ((def_mount_opts & EXT4_DEFM_NODELALLOC) == 0)) set_opt(sb, DELALLOC);