# Re: \[PATCH\] libext2fs: When truncating file, punch out blocks at end

- From: Ted Ts'o \<tytso@mit.edu\>
- Date: 2012-02-15 20:12:48 
- List: linux-ext4
- Page: https://ratatoskr.run/linux-ext4/2012/02/13414210
- Thread: https://ratatoskr.run/linux-ext4/2012/01/13413844/t.md

```text
On Fri, Jan 06, 2012 at 08:47:37PM -0800, Darrick J. Wong wrote:
> Currently, ext2fs_file_set_size2 punches out data blocks between the
> end of the file and infinity when truncate_block <= old_truncate
> (i.e. when you've made the file longer).  This is not a useful
> behavior, particularly since it *fails* to punch out the data blocks
> when the file is shortened (i.e. truncate_block < old_truncate).
> This seems to be the result of the test being backwards, so fix the
> code to punch only when the file is getting shorter.
> 
> Signed-off-by: Darrick J. Wong <redacted>

Thanks, applied.

						- Ted
```
