# \[PATCH\] ext4/fsync.c: functions should not be declared extern

- From: H Hartley Sweeten \<hidden\>
- Date: 2011-09-23 22:14:20 
- List: linux-ext4
- Page: https://ratatoskr.run/linux-ext4/2011/09/3766975
- Thread: https://ratatoskr.run/linux-ext4/2011/09/3766975/t.md

```text
The function declaration in ext4.h is already marked extern.  The function
definition should not have the tag.

This quiets the sparse noise:

warning: function 'ext4_flush_completed_IO' with external linkage has definition

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>

---

diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index 036f78f..c942924 100644
--- a/fs/ext4/fsync.c
+++ b/fs/ext4/fsync.c
@@ -75,7 +75,7 @@ static void dump_completed_IO(struct inode * inode)
  * to written.
  * The function return the number of pending IOs on success.
  */
-extern int ext4_flush_completed_IO(struct inode *inode)
+int ext4_flush_completed_IO(struct inode *inode)
 {
 	ext4_io_end_t *io;
 	struct ext4_inode_info *ei = EXT4_I(inode);
```
