Re: [PATCH 1/5] ext4 online defrag header file changes

From: Akira Fujita <hidden>
Date: 2008-03-24 12:34:51
Also in: linux-fsdevel

Hi Aneesh,
On Mon, Mar 24, 2008 at 08:00:54PM +0900, Akira Fujita wrote:
quoted
quoted
  
Is EXT4_IOC_FIEMAP going to be added to the ext4 patch queue?
I will try to use EXT4_IOC_FIEMAP instead of EXT4_IOC_EXTENTS_INFO
in ext4 online defrag when kernel supports it.
Can you also look at the sparse warnings with the patches ?
I have already released the fixed patch before, but it is not in the ext4 patch queue yet.
Mingming, could you replace new ext4-online-defrag-free-space-fragmentation.patch
with old one in the ext4 patch queue? 

Regards, Akira

Signed-off-by: Akira Fujita <redacted>
---
 defrag.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff -Nurp linux-2.6.25-rc6-full/fs/ext4/defrag.c linux-2.6.25-rc6-fix/fs/ext4/defrag.c
--- linux-2.6.25-rc6-full/fs/ext4/defrag.c    2008-03-24 20:37:10.000000000 +0900
+++ linux-2.6.25-rc6-fix/fs/ext4/defrag.c    2008-03-24 20:40:22.000000000 +0900
@@ -454,7 +454,7 @@ static int ext4_defrag_move_victim(struc
             ext_info->ext[i].len, goal, DEFRAG_FORCE_VICTIM, &ext);
         if (ret < 0) {
             printk(KERN_ERR "ext4 defrag: "
-                "Moving victim file failed. ino [%lu]\n",
+                "Moving victim file failed. ino [%llu]\n",
                 ext_info->ino);
             goto err;
         }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help