Re: [RFC][PATCH 2/3] ext4 online defrag (ver 0.7)

From
Akira Fujita <hidden>
Date
2008-03-19 01:05:33
Also in
linux-fsdevel
Hello Solofo,
Hello,

Akira Fujita writes:
 > -			printk(KERN_ERR "defrag: failed ext4_ext_defrag\n");
 > -			goto ERR;
 > +			printk(KERN_ERR "ext4 defrag: "
 > +				"Moving victim file failed. ino [%lu]\n",
 > +				ext_info->ino);

This triggers this warning:
fs/ext4/defrag.c: In function 'ext4_defrag_move_victim':
fs/ext4/defrag.c:458: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'long long unsigned int'

(ext4-online-defrag-free-space-fragmentation.patch from ext4-patch-queue 36c86f09d6ac97c2797a1a94d76e2fc1dc3b03f8)
Thank you for notification.
And sorry for the delay fix, it has already been pointed out by Mingming.

Mingming, could you replace attached file with ext4 patch queue's ?

Regards Akira, 


Signed-off-by: Akira Fujita <redacted>
---
 defrag.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.25-rc5-ext4-org/fs/ext4/defrag.c	2008-03-19 07:16:40.000000000 +0900
+++ linux-2.6.25-rc5-full/fs/ext4/defrag.c	2008-03-19 08:31:01.000000000 +0900
@@ -454,7 +454,7 @@ static int ext4_defrag_move_victim(struc
 			ext_info->ext[i].len, goal, DEFRAG_FORCE_VICTIM, &ext);
 		if (ret < 0) {
 			printk(KERN_ERR "ext4 defrag: "
-				"Moving victim file failed. ino [%lu]\n",
+				"Moving victim file failed. ino [%llu]\n",
 				ext_info->ino);
 			goto err;
 		}

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help