DORMANTno replies

[PATCH] EDAC/amd64: Do not warn when removing instances

From: Borislav Petkov <bp@alien8.de>
Date: 2020-01-17 11:59:53
Also in: lkml
Subsystem: edac-amd64, edac-core, the rest · Maintainers: Yazen Ghannam, Borislav Petkov, Tony Luck, Linus Torvalds

From: Borislav Petkov <redacted>

On machines which do not populate all nodes with DIMMs, the driver
doesn't initialize an instance there. However, the instance removal
remove_one_instance() path will warn unconditionally, which is wrong.

Remove the WARN_ON() even if the warning is innocent because it causes a
splat in dmesg.

Signed-off-by: Borislav Petkov <redacted>
---
 drivers/edac/amd64_edac.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 428ce98f6776..d2a6d3319650 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -3573,9 +3573,6 @@ static void remove_one_instance(unsigned int nid)
 	struct mem_ctl_info *mci;
 	struct amd64_pvt *pvt;
 
-	mci = find_mci_by_dev(&F3->dev);
-	WARN_ON(!mci);
-
 	/* Remove from EDAC CORE tracking list */
 	mci = edac_mc_del_mc(&F3->dev);
 	if (!mci)
-- 
2.21.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help