[linux-next:master 7602/7933] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:37: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
From: kernel test robot <hidden>
Date: 2023-08-08 07:00:57
Also in:
linux-mm, oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 71cd4fc492ec41e4acd85e98bbf7a13753fc1e03 commit: c7ddc0a800bc9f681a18c3bdd9f06b61adfabc11 [7602/7933] drm/amd/display: Add Functions to enable Freesync Panel Replay config: xtensa-randconfig-r022-20230808 (https://download.01.org/0day-ci/archive/20230808/202308081459.US5rLYAY-lkp@intel.com/config) compiler: xtensa-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230808/202308081459.US5rLYAY-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot [off-list ref] | Closes: https://lore.kernel.org/oe-kbuild-all/202308081459.US5rLYAY-lkp@intel.com/ (local) All warnings (new ones prefixed by >>):
quoted
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:37: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Get Replay state from firmware.
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:66: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Enable/Disable Replay.
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:116: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Set REPLAY power optimization flags.
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:134: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Setup Replay by programming phy registers and sending replay hw context values to firmware.
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:219: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Set coasting vtotal.
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:238: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Get Replay residency from firmware.
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:271: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Construct Replay object.
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:280: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Allocate and initialize Replay object.
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c:297: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Deallocate Replay object.
vim +37 drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_replay.c
35
36 /**
> 37 * Get Replay state from firmware.
38 */
39 static void dmub_replay_get_state(struct dmub_replay *dmub, enum replay_state *state, uint8_t panel_inst)
40 {
41 struct dmub_srv *srv = dmub->ctx->dmub_srv->dmub;
42 /* uint32_t raw_state = 0; */
43 uint32_t retry_count = 0;
44 enum dmub_status status;
45
46 do {
47 // Send gpint command and wait for ack
48 status = dmub_srv_send_gpint_command(srv, DMUB_GPINT__GET_REPLAY_STATE, panel_inst, 30);
49
50 if (status == DMUB_STATUS_OK) {
51 // GPINT was executed, get response
52 dmub_srv_get_gpint_response(srv, (uint32_t *)state);
53 } else
54 // Return invalid state when GPINT times out
55 *state = REPLAY_STATE_INVALID;
56 } while (++retry_count <= 1000 && *state == REPLAY_STATE_INVALID);
57
58 // Assert if max retry hit
59 if (retry_count >= 1000 && *state == REPLAY_STATE_INVALID) {
60 ASSERT(0);
61 /* To-do: Add retry fail log */
62 }
63 }
64
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki