-----Original Message-----
From: Kani, Toshi <redacted>
Sent: Thursday, August 25, 2022 7:04 AM
To: Justin He <redacted>; Len Brown <lenb@kernel.org>; James
Morse [off-list ref]; Tony Luck [off-list ref]; Borislav
Petkov [off-list ref]; Mauro Carvalho Chehab [off-list ref];
Robert Richter [off-list ref]; Robert Moore [off-list ref];
Qiuxu Zhuo [off-list ref]; Yazen Ghannam
[off-list ref]; Jonathan Corbet [off-list ref]; Jan
Luebbe [off-list ref]; Khuong Dinh
[off-list ref]
Cc: Ard Biesheuvel <ardb@kernel.org>; linux-acpi@vger.kernel.org;
linux-kernel@vger.kernel.org; linux-edac@vger.kernel.org; devel@acpica.org;
Rafael J . Wysocki [off-list ref]; Shuai Xue
[off-list ref]; Jarkko Sakkinen [off-list ref];
linux-efi@vger.kernel.org; nd [off-list ref]; Paul E. McKenney
[off-list ref]; Andrew Morton [off-list ref];
Neeraj Upadhyay [off-list ref]; Randy Dunlap
[off-list ref]; Damien Le Moal
[off-list ref]; Muchun Song
[off-list ref]; linux-doc@vger.kernel.org
Subject: RE: [RESEND PATCH v3 5/9] EDAC: Don't load chipset-specific edac
drivers when ghes_edac is preferred

On Monday, August 22, 2022 9:41 AM, Jia He wrote:

quoted

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index

e17e0ee8f842..327386f3cf33 100644

--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c

@@ -1537,16 +1537,25 @@ static struct acpi_platform_list plat_list[] = {
 	{ } /* End */
 };

-struct list_head *ghes_get_devices(void)
+bool ghes_edac_preferred(void)
 {
 	int idx = -1;

 	if (IS_ENABLED(CONFIG_X86)) {
 		idx = acpi_match_platform_list(plat_list);
 		if (idx < 0 && !ghes_edac_force)
-			return NULL;
+			return false;
 	}

+	return true;
+}
+EXPORT_SYMBOL_GPL(ghes_edac_preferred);
+
+struct list_head *ghes_get_devices(void) {
+	if (!ghes_edac_preferred())
+		return NULL;
+
 	return &ghes_devs;
 }

ghes_get_devices() changing multiple times in the series is
confusing to me.   Can you simply introduce ghes_get_devices()
and ghes_preferred() in the right state in a patch?  Perhaps, patch #2, #5, #6
can collapse to introduce the two funcs?

My purpose was to make it easy for review. I am ok to merge these patches into one.

The rest of patch #5 adding the call to ghes_edac_preferred() into other edac
drivers can remain as a separate patch.

Okay, I assume you mean to merge all of the ghes_edac_preferred() checking for intel and
Arm edac drivers into 1 separate patch, am I understanding well?


--
Cheers,
Justin (Jia He)