# Re: \[PATCH v8 09/12\] sysfs: fix deadlock race with module removal

- From: Luis Chamberlain \<mcgrof@kernel.org\>
- Date: 2021-10-13 12:42:05 
- List: linux-doc
- Page: https://ratatoskr.run/linux-doc/2021/10/215903
- Thread: https://ratatoskr.run/linux-doc/2021/09/215052/t.md

```text
On Mon, Oct 11, 2021 at 03:26:02PM -0700, Luis Chamberlain wrote:
> On Tue, Oct 05, 2021 at 01:50:31PM -0700, Kees Cook wrote:
> > For example, why does this not work?
> 
> It does for the write case for sure,

I mispoke, just for the record, the changes you mentioned actually don't
suffice for the test cases in question for test_sysfs, the deadlock
still occurs with those changes. At first I thought it did but I had failed
to remove my own fix first on fs/kernfs/dir.c. After removing that and
just trying the proposed changes I confirm it does not fix the deadlock.

  Luis
```
