# Re: \[PATCH -rcu/kcsan 16/23\] locking/atomics, kcsan: Add instrumentation for barriers

- From: Peter Zijlstra \<peterz@infradead.org\>
- Date: 2021-10-05 12:04:09 
- List: linux-doc
- Page: https://ratatoskr.run/linux-doc/2021/10/1531350
- Thread: https://ratatoskr.run/linux-arch/2021/10/1531275/t.md

```text
On Tue, Oct 05, 2021 at 12:58:58PM +0200, Marco Elver wrote:
> @@ -59,6 +60,7 @@ atomic_add(int i, atomic_t *v)
>  static __always_inline int
>  atomic_add_return(int i, atomic_t *v)
>  {
> +	kcsan_mb();
>  	instrument_atomic_read_write(v, sizeof(*v));
>  	return arch_atomic_add_return(i, v);
>  }

This and others,.. is this actually correct? Should that not be
something like:

	kscan_mb();
	instrument_atomic_read_write(...);
	ret = arch_atomic_add_return(i, v);
	kcsan_mb();
	return ret;

?
```
