@@ -417,6 +417,9 @@ definitions of that choice. If a [symbol] is associated to the choice, then you may define the same choice (i.e. with the same entries) in another place.+The default value of a choice is set to the first visible choice element.+Choice elements do not support the default attribute like menu entries do.+ comment:: "comment" <prompt>
@@ -417,6 +417,9 @@ definitions of that choice. If a [symbol] is associated to the choice, then you may define the same choice (i.e. with the same entries) in another place.+The default value of a choice is set to the first visible choice element.
The default value of a choice is set to the first visible choice element
unless it is explicitly set by the 'default' property.
... is more precise.
+Choice elements do not support the default attribute like menu entries do.
I doubt this info is useful.
Rather, is it even confusing?
choices support 'default' but
choice elements (i.e. choice values) do not.
@@ -417,6 +417,9 @@ definitions of that choice. If a [symbol] is associated to the choice, then you may define the same choice (i.e. with the same entries) in another place.+The default value of a choice is set to the first visible choice element.
The default value of a choice is set to the first visible choice element
unless it is explicitly set by the 'default' property.
... is more precise.
Ah, ok. It becomes clear now, but how a value is set then in case the
type is tristate?
quoted
+Choice elements do not support the default attribute like menu entries do.
I doubt this info is useful.
Rather, is it even confusing?
choices support 'default' but
choice elements (i.e. choice values) do not.
I have added an example to the doc for clarification, v2 below.
Thanks,
-Robert
From 46ebd10dc11388ddce40aea70890000697a27165 Mon Sep 17 00:00:00 2001
From: Robert Richter <redacted>
Date: Wed, 14 Jul 2021 12:24:16 +0200
Subject: [PATCH v2] Documentation/kbuild: Document the kconfig choice default
value
Document how choice defaults are determined:
Default of a choice is its first visible choice element unless it is
explicitly set by the 'default' property [1]. Choice elements do not
support default attributes. [2]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/kconfig/symbol.c?h=v5.14-rc1#n245
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/kconfig/menu.c?h=v5.14-rc1#n494
Signed-off-by: Robert Richter <redacted>
---
v2: clarification on 'default' attribute of a choice
added example
---
Documentation/kbuild/kconfig-language.rst | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
@@ -417,8 +417,20 @@ definitions of that choice. If a [symbol] is associated to the choice, then you may define the same choice (i.e. with the same entries) in another place.-The default value of a choice is set to the first visible choice element.-Choice elements do not support the default attribute like menu entries do.+The default value of a choice is set to the first visible choice+element unless it is explicitly set by the 'default' property.++Note:+ Choice options do not support the 'default' attribute.++E.g.::++ choice+ default C1+ config C0+ config C1+ # no default attribute here+ endchoice comment::
From: Robert Richter <hidden> Date: 2021-07-19 20:47:20
On 19.07.21 11:16:09, Robert Richter wrote:
quoted hunk
@@ -417,8 +417,20 @@ definitions of that choice. If a [symbol] is associated to the choice, then you may define the same choice (i.e. with the same entries) in another place.-The default value of a choice is set to the first visible choice element.-Choice elements do not support the default attribute like menu entries do.
This patch was not properly rebased and does not apply. Will resend a v3.
Sorry for that.
-Robert
+The default value of a choice is set to the first visible choice
+element unless it is explicitly set by the 'default' property.
+
+Note:
+ Choice options do not support the 'default' attribute.
+
+E.g.::
+
+ choice
+ default C1
+ config C0
+ config C1
+ # no default attribute here
+ endchoice
comment::
--
2.29.2
@@ -417,6 +417,21 @@ definitions of that choice. If a [symbol] is associated to the choice, then you may define the same choice (i.e. with the same entries) in another place.+The default value of a choice is set to the first visible choice+element unless it is explicitly set by the 'default' property.++Note:+ Choice options do not support the 'default' attribute.++E.g.::++ choice+ default C1+ config C0+ config C1+ # no default attribute here+ endchoice+ comment:: "comment" <prompt>
@@ -417,6 +417,21 @@ definitions of that choice. If a [symbol] is associated to the choice, then you may define the same choice (i.e. with the same entries) in another place.+The default value of a choice is set to the first visible choice+element unless it is explicitly set by the 'default' property.++Note:+ Choice options do not support the 'default' attribute.++E.g.::++ choice+ default C1+ config C0+ config C1+ # no default attribute here+ endchoice+ comment:: "comment" <prompt>--
2.29.2
I am not sure whether this note is needed or not,
anyway the code example is wrong.
Kconfig:3:warning: config symbol defined without type
Kconfig:4:warning: config symbol defined without type
Kconfig:3:warning: choice value must have a prompt
Kconfig:4:warning: choice value must have a prompt
Kconfig:1:warning: config symbol defined without type
Kconfig:1:warning: choice must have a prompt
--
Best Regards
Masahiro Yamada