# \[PATCH\] x86/sgx: fix incorrect kernel-doc comment syntax in files - Subsystems: INTEL SGX, THE REST, X86 ARCHITECTURE (32-BIT AND 64-BIT) - Maintainers: Jarkko Sakkinen, Linus Torvalds, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen - List: linux-doc - 3 messages, 3 authors - Page: https://ratatoskr.run/linux-doc/2021/03/6321821/t ## \[PATCH\] x86/sgx: fix incorrect kernel-doc comment syntax in files - From: Aditya Srivastava \ - Date: 2021-03-30 21:19:09 - Message: https://ratatoskr.run/linux-doc/2021/03/6321821.md ```text The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. There are certain files in arch/x86/kernel/cpu/sgx, which follow this syntax, but the content inside does not comply with kernel-doc. Such lines were probably not meant for kernel-doc parsing, but are parsed due to the presence of kernel-doc like comment syntax(i.e, '/**'), which causes unexpected warnings from kernel-doc. E.g., presence of kernel-doc like comment in the header lines for arch/x86/kernel/cpu/sgx/encl.h causes this warning: "warning: expecting prototype for 2016(). Prototype was for _X86_ENCL_H() instead" Similarly for arch/x86/kernel/cpu/sgx/arch.h too. Provide a simple fix by replacing these occurrences with general comment format, i.e. '/*', to prevent kernel-doc from parsing it. Signed-off-by: Aditya Srivastava --- * Applies perfectly on next-20210326 arch/x86/kernel/cpu/sgx/arch.h | 2 +- arch/x86/kernel/cpu/sgx/encl.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/cpu/sgx/arch.h b/arch/x86/kernel/cpu/sgx/arch.h index 26315bea1cb4..70b84bbdaa1d 100644 --- a/arch/x86/kernel/cpu/sgx/arch.h +++ b/arch/x86/kernel/cpu/sgx/arch.h @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0 */ -/** +/* * Copyright(c) 2016-20 Intel Corporation. * * Contains data structures defined by the SGX architecture. Data structures diff --git a/arch/x86/kernel/cpu/sgx/encl.h b/arch/x86/kernel/cpu/sgx/encl.h index d8d30ccbef4c..76b9bc1c5c30 100644 --- a/arch/x86/kernel/cpu/sgx/encl.h +++ b/arch/x86/kernel/cpu/sgx/encl.h @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0 */ -/** +/* * Copyright(c) 2016-20 Intel Corporation. * * Contains the software defined data structures for enclaves. -- 2.17.1 ``` ## Re: \[PATCH\] x86/sgx: fix incorrect kernel-doc comment syntax in files - From: Randy Dunlap \ - Date: 2021-03-30 21:21:20 - Message: https://ratatoskr.run/linux-doc/2021/03/6321824.md ```text On 3/30/21 2:18 PM, Aditya Srivastava wrote: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > There are certain files in arch/x86/kernel/cpu/sgx, which follow this > syntax, but the content inside does not comply with kernel-doc. > Such lines were probably not meant for kernel-doc parsing, but are parsed > due to the presence of kernel-doc like comment syntax(i.e, '/**'), which > causes unexpected warnings from kernel-doc. > > E.g., presence of kernel-doc like comment in the header lines for > arch/x86/kernel/cpu/sgx/encl.h causes this warning: > "warning: expecting prototype for 2016(). Prototype was for _X86_ENCL_H() instead" > > Similarly for arch/x86/kernel/cpu/sgx/arch.h too. > > Provide a simple fix by replacing these occurrences with general comment > format, i.e. '/*', to prevent kernel-doc from parsing it. > > Signed-off-by: Aditya Srivastava Acked-by: Randy Dunlap > --- > * Applies perfectly on next-20210326 > > arch/x86/kernel/cpu/sgx/arch.h | 2 +- > arch/x86/kernel/cpu/sgx/encl.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/sgx/arch.h b/arch/x86/kernel/cpu/sgx/arch.h > index 26315bea1cb4..70b84bbdaa1d 100644 > --- a/arch/x86/kernel/cpu/sgx/arch.h > +++ b/arch/x86/kernel/cpu/sgx/arch.h > @@ -1,5 +1,5 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > -/** > +/* > * Copyright(c) 2016-20 Intel Corporation. > * > * Contains data structures defined by the SGX architecture. Data structures > diff --git a/arch/x86/kernel/cpu/sgx/encl.h b/arch/x86/kernel/cpu/sgx/encl.h > index d8d30ccbef4c..76b9bc1c5c30 100644 > --- a/arch/x86/kernel/cpu/sgx/encl.h > +++ b/arch/x86/kernel/cpu/sgx/encl.h > @@ -1,5 +1,5 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > -/** > +/* > * Copyright(c) 2016-20 Intel Corporation. > * > * Contains the software defined data structures for enclaves. > -- ~Randy ``` ## Re: \[PATCH\] x86/sgx: fix incorrect kernel-doc comment syntax in files - From: Jarkko Sakkinen \ - Date: 2021-03-31 02:57:05 - Message: https://ratatoskr.run/linux-doc/2021/03/6322047.md ```text On Wed, Mar 31, 2021 at 02:48:13AM +0530, Aditya Srivastava wrote: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > There are certain files in arch/x86/kernel/cpu/sgx, which follow this > syntax, but the content inside does not comply with kernel-doc. > Such lines were probably not meant for kernel-doc parsing, but are parsed > due to the presence of kernel-doc like comment syntax(i.e, '/**'), which > causes unexpected warnings from kernel-doc. > > E.g., presence of kernel-doc like comment in the header lines for > arch/x86/kernel/cpu/sgx/encl.h causes this warning: > "warning: expecting prototype for 2016(). Prototype was for _X86_ENCL_H() instead" > > Similarly for arch/x86/kernel/cpu/sgx/arch.h too. > > Provide a simple fix by replacing these occurrences with general comment > format, i.e. '/*', to prevent kernel-doc from parsing it. > > Signed-off-by: Aditya Srivastava > --- > * Applies perfectly on next-20210326 > > arch/x86/kernel/cpu/sgx/arch.h | 2 +- > arch/x86/kernel/cpu/sgx/encl.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/sgx/arch.h b/arch/x86/kernel/cpu/sgx/arch.h > index 26315bea1cb4..70b84bbdaa1d 100644 > --- a/arch/x86/kernel/cpu/sgx/arch.h > +++ b/arch/x86/kernel/cpu/sgx/arch.h > @@ -1,5 +1,5 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > -/** > +/* > * Copyright(c) 2016-20 Intel Corporation. > * > * Contains data structures defined by the SGX architecture. Data structures > diff --git a/arch/x86/kernel/cpu/sgx/encl.h b/arch/x86/kernel/cpu/sgx/encl.h > index d8d30ccbef4c..76b9bc1c5c30 100644 > --- a/arch/x86/kernel/cpu/sgx/encl.h > +++ b/arch/x86/kernel/cpu/sgx/encl.h > @@ -1,5 +1,5 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > -/** > +/* > * Copyright(c) 2016-20 Intel Corporation. > * > * Contains the software defined data structures for enclaves. > -- > 2.17.1 > > Acked-by: Jarkko Sakkinen /Jarkko ```