# Re: \[PATCH v23 21/28\] mm: Re-introduce vm\_flags to do\_mmap()

- From: Yu, Yu-cheng \<hidden\>
- Date: 2021-03-18 16:00:26 
- List: linux-doc
- Page: https://ratatoskr.run/linux-doc/2021/03/6306533
- Thread: https://ratatoskr.run/linux-doc/2021/03/6303369/t.md

```text
On 3/18/2021 4:42 AM, Borislav Petkov wrote:
> On Tue, Mar 16, 2021 at 08:10:47AM -0700, Yu-cheng Yu wrote:
>> There was no more caller passing vm_flags to do_mmap(), and vm_flags was
>> removed from the function's input by:
>>
>>      commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()").
>>
>> There is a new user now.  Shadow stack allocation passes VM_SHSTK to
>> do_mmap().  Re-introduce vm_flags to do_mmap(), but without the old wrapper
>> do_mmap_pgoff().
>
> Why does this matter at all?
>
> $ git grep do_mmap_pgoff
> $
>

Right, do_mmap_pgoff() was removed by commit 45e55300f114.  This patch does not add back the wrapper.  Instead, add vm_flags to do_mmap(). Please advice if I misunderstand the question.

Thanks,
Yu-cheng
```