# Re: \[RFT PATCH v3 21/27\] tty: serial: samsung\_tty: IRQ rework

- From: Krzysztof Kozlowski \<hidden\>
- Date: 2021-03-05 10:53:03 
- List: linux-doc
- Page: https://ratatoskr.run/linux-doc/2021/03/6289436
- Thread: https://ratatoskr.run/linux-arm-kernel/2021/03/6288800/t.md

```text
On 04/03/2021 22:38, Hector Martin wrote:
> * Split out s3c24xx_serial_tx_chars from s3c24xx_serial_tx_irq,
>   where only the latter acquires the port lock. This will be necessary
>   on platforms which have edge-triggered IRQs, as we need to call
>   s3c24xx_serial_tx_chars to kick off transmission from outside IRQ
>   context, with the port lock held.
> 
> * Rename s3c24xx_serial_rx_chars to s3c24xx_serial_rx_irq for
>   consistency with the above. All it does now is call two other
>   functions anyway.
> 
> Signed-off-by: Hector Martin <redacted>
> ---
>  drivers/tty/serial/samsung_tty.c | 34 +++++++++++++++++++-------------
>  1 file changed, 20 insertions(+), 14 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <redacted>
Tested-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof
```
