# Re: \[RFT PATCH v3 20/27\] tty: serial: samsung\_tty: Add s3c24xx\_port\_type

- From: Krzysztof Kozlowski \<hidden\>
- Date: 2021-03-05 10:50:17 
- List: linux-doc
- Page: https://ratatoskr.run/linux-doc/2021/03/6289432
- Thread: https://ratatoskr.run/linux-arm-kernel/2021/03/6288800/t.md

```text

On 04/03/2021 22:38, Hector Martin wrote:
> This decouples the TTY layer PORT_ types, which are exposed to
> userspace, from the driver-internal flag of what kind of port this is.

s/This decouples/Decouple

> 
> This removes s3c24xx_serial_has_interrupt_mask, which was just checking

s/This removes/Remove/

https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L89

This actually also applies to your patch 19 and 21... and maybe more.

> for a specific type anyway.
> 
> Signed-off-by: Hector Martin <redacted>
> ---
>  drivers/tty/serial/samsung_tty.c | 112 +++++++++++++++++++------------
>  1 file changed, 70 insertions(+), 42 deletions(-)
> 
Reviewed-by: Krzysztof Kozlowski <redacted>
Tested-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof
```