# Re: \[PATCH v6 66/80\] locking/refcount: document the new "oldp" pointer value

- From: Peter Zijlstra \<peterz@infradead.org\>
- Date: 2020-10-13 12:48:08 
- List: linux-doc
- Page: https://ratatoskr.run/linux-doc/2020/10/6138645
- Thread: https://ratatoskr.run/linux-doc/2020/10/6138538/t/2.md

```text
On Tue, Oct 13, 2020 at 01:54:21PM +0200, Mauro Carvalho Chehab wrote:
> Changeset a435b9a14356 ("locking/refcount: Provide __refcount API to obtain the old value")
> added a new parameter to most refcount functions, but didn't update
> the kernel-doc markups.

Mindless warning begets mindless patch :/ Please turn on brain while
operating the computer.

> Add a description for it on all touched functions.

It's actively wrong now, the function in the comment is the variant with
__ and they do not have the extra parameter.

> Fixes: a435b9a14356 ("locking/refcount: Provide __refcount API to obtain the old value")

Breaks actual sanity.
```