Hi James,
Hi Dongjiu Geng,
On 03/03/18 16:09, Dongjiu Geng wrote:
quoted
Export one API to specify virtual SEI syndrome value for guest, and
add a helper to get the VSESR_EL2 value.
This patch adds two helpers that nothing calls... its not big, please merge it with the patch that uses these.
OK, thanks, I will merge them.
quoted
diff --git a/arch/arm64/include/asm/kvm_emulate.h
b/arch/arm64/include/asm/kvm_emulate.h
index 413dc82..3294885 100644
--- a/arch/arm64/include/asm/kvm_emulate.h
+++ b/arch/arm64/include/asm/kvm_emulate.h
@@ -71,6 +71,11 @@ static inline void vcpu_set_hcr(struct kvm_vcpu *vcpu, unsigned long hcr)
vcpu->arch.hcr_el2 = hcr;
}
+static inline unsigned long vcpu_get_vsesr(struct kvm_vcpu *vcpu) {
+ return vcpu->arch.vsesr_el2;
+}
+
static inline void vcpu_set_vsesr(struct kvm_vcpu *vcpu, u64 vsesr){
vcpu->arch.vsesr_el2 = vsesr;diff --git a/arch/arm64/include/asm/kvm_host.h
b/arch/arm64/include/asm/kvm_host.h
index a73f63a..3dc49b7 100644
--- a/arch/arm64/include/asm/kvm_host.h
+++ b/arch/arm64/include/asm/kvm_host.h
@@ -354,6 +354,8 @@ void handle_exit_early(struct kvm_vcpu *vcpu,
struct kvm_run *run, int kvm_perf_init(void); int
kvm_perf_teardown(void);
+void kvm_set_sei_esr(struct kvm_vcpu *vcpu, u64 syndrome);
+
struct kvm_vcpu *kvm_mpidr_to_vcpu(struct kvm *kvm, unsigned long
mpidr);
static inline void __cpu_init_hyp_mode(phys_addr_t pgd_ptr, diff
--git a/arch/arm64/kvm/inject_fault.c b/arch/arm64/kvm/inject_fault.c
index 60666a0..78ecb28 100644
--- a/arch/arm64/kvm/inject_fault.c
+++ b/arch/arm64/kvm/inject_fault.c
@@ -186,3 +186,8 @@ void kvm_inject_vabt(struct kvm_vcpu *vcpu) {
pend_guest_serror(vcpu, ESR_ELx_ISV); }
+
+void kvm_set_sei_esr(struct kvm_vcpu *vcpu, u64 syndrome) {
+ pend_guest_serror(vcpu, syndrome & ESR_ELx_ISS_MASK);
If you move the ISS_MASK into pend_guest_serror(), you wouldn't need this at all.
It would be better if any validation were in the user-space helpers so we can check user-space hasn't put something funny in the top bits.
Yes, I agree your idea, thanks for the good suggestion.
quoted
+}
Thanks,
James
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html