# Re: \[PATCH v12 02/22\] selftests/vm: rename all references to pkru to a generic name

- From: Dave Hansen \<hidden\>
- Date: 2018-03-16 21:55:35 
- List: linux-doc
- Page: https://ratatoskr.run/linux-doc/2018/03/5218948
- Thread: https://ratatoskr.run/linux-kselftest/2018/02/5195852/t.md

```text
On 02/21/2018 05:55 PM, Ram Pai wrote:
>  int pkey_set(int pkey, unsigned long rights, unsigned long flags)
>  {
>  	u32 mask = (PKEY_DISABLE_ACCESS|PKEY_DISABLE_WRITE);
> -	u32 old_pkru = __rdpkru();
> -	u32 new_pkru;
> +	u32 old_pkey_reg = __rdpkey_reg();
> +	u32 new_pkey_reg;

If we're not using the _actual_ instruction names ("rdpkru"), I think
I'd rather this be something more readable, like: __read_pkey_reg().

But, it's OK-ish the way it is.

Reviewed-by: Dave Hansen <redacted>
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
```