# Re: \[PATCH v12 07/22\] selftests/vm: fixed bugs in pkey\_disable\_clear()

- From: Thiago Jung Bauermann \<hidden\>
- Date: 2018-03-28 23:52:00 
- List: linux-doc
- Page: https://ratatoskr.run/linux-doc/2018/03/5218928
- Thread: https://ratatoskr.run/linux-kselftest/2018/02/5195852/t.md

```text

Dave Hansen [ref] writes:

> On 03/28/2018 01:47 PM, Thiago Jung Bauermann wrote:
>>>>  	if (flags)
>>>> -		assert(rdpkey_reg() > orig_pkey_reg);
>>>> +		assert(rdpkey_reg() < orig_pkey_reg);
>>>>  }
>>>>
>>>>  void pkey_write_allow(int pkey)
>>> This seems so horribly wrong that I wonder how it worked in the first
>>> place.  Any idea?
>> The code simply wasn't used. pkey_disable_clear() is called by
>> pkey_write_allow() and pkey_access_allow(), but before this patch series
>> nothing called either of these functions.
>> 
>
> Ahh, that explains it.  Can that get stuck in the changelog, please?

Yes, will be in the next version.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
```