[PATCH] dt-bindings: phy: qcom: Relax required supplies

Subsystems: arm/qualcomm mailing list, generic phy framework, open firmware and flattened device tree bindings, the rest

COLD17d

2 messages, 2 authors, 17d ago · open the first message on its own page

[PATCH] dt-bindings: phy: qcom: Relax required supplies

From: "Rob Herring (Arm)" <robh@kernel.org>
Date: 2026-09-21 23:26:07

For the QUSB2 PHY binding, keep the three regulator supplies required
except for legacy IPQ6018 nodes that do not describe the board rails.

Assisted-by: LLM
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
index 001fd0ccc985..2516eab7f6d3 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
@@ -165,12 +165,23 @@ required:
   - "#phy-cells"
   - clocks
   - clock-names
-  - vdd-supply
-  - vdda-pll-supply
-  - vdda-phy-dpdm-supply
   - resets
 
 allOf:
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum: 
+                - qcom,ipq6018-qusb2-phy
+                - qcom,ipq8074-qusb2-phy
+    then:
+      required:
+        - vdd-supply
+        - vdda-pll-supply
+        - vdda-phy-dpdm-supply
+
   - if:
       not:
         properties:
-- 
2.53.0

Re: [PATCH] dt-bindings: phy: qcom: Relax required supplies

From: sashiko-bot@kernel.org
Date: 2026-09-21 23:34:25

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: unintended schema relaxation for qcom,ipq5210-qusb2-phy
--

commit 69ee638f4004f6e325a963f3b804b3c1cac5c6fb
Author: Rob Herring (Arm) [off-list ref]

dt-bindings: phy: qcom: Relax required supplies

This commit relaxes the requirement for three regulator supplies in the QUSB2
PHY binding for legacy IPQ6018 nodes that do not describe board rails.
quoted hunk
diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
index 001fd0ccc9852..2516eab7f6d32 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
[ ... ]
quoted hunk
 allOf:
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum: 
+                - qcom,ipq6018-qusb2-phy
+                - qcom,ipq8074-qusb2-phy
[Severity: Medium]
Does this unintentionally relax the schema requirements for IPQ5210?

Since qcom,ipq5210-qusb2-phy falls back to qcom,ipq6018-qusb2-phy, an IPQ5210
device tree node's compatible array will contain qcom,ipq6018-qusb2-phy.

The 'contains: enum' logic matches this fallback, which seems like it might
incorrectly apply this legacy IPQ6018 exemption to IPQ5210 nodes, allowing
them to silently pass schema validation without the required regulator
supplies.
quoted hunk
+    then:
+      required:
+        - vdd-supply
+        - vdda-pll-supply
+        - vdda-phy-dpdm-supply
-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921232603.3129898-1-robh@kernel.org?part=1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help