[PATCH] dt-bindings: soc: mediatek: Allow pwrap regs

Subsystems: open firmware and flattened device tree bindings, the rest

COLD16d

4 messages, 3 authors, 16d ago · open the first message on its own page

[PATCH] dt-bindings: soc: mediatek: Allow pwrap regs

From: "Rob Herring (Arm)" <robh@kernel.org>
Date: 2026-09-21 23:25:39

The MT7622 PMIC wrapper has a regulators child node. Add the child
schema reference so regulator subnodes are evaluated by the MT6380
regulator binding instead of being rejected.

Assisted-by: Codex:gpt-5-5
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml       | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
index e7c4a3984c60..79b755858bad 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
@@ -105,6 +105,9 @@ properties:
   pmic:
     type: object
 
+  regulators:
+    $ref: /schemas/regulator/mediatek,mt6380-regulator.yaml#
+
 required:
   - compatible
   - reg
-- 
2.53.0

Re: [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs

From: sashiko-bot@kernel.org
Date: 2026-09-21 23:31:09

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing referenced mediatek,mt6380-regulator.yaml schema
--

commit 73b0295b13e9c91b5f296071d21498bc710f649e
Author: Rob Herring (Arm) [off-list ref]

dt-bindings: soc: mediatek: Allow pwrap regs

This commit updates the MT7622 PMIC wrapper binding to add a child schema
reference for regulators. This change routes regulator subnodes to the
MT6380 regulator binding for evaluation.
quoted hunk
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
@@ -105,6 +105,9 @@ properties:
   pmic:
     type: object
 
+  regulators:
+    $ref: /schemas/regulator/mediatek,mt6380-regulator.yaml#
[Severity: Low]
Does this introduce an invalid schema reference for the regulators property?

It appears the referenced mediatek,mt6380-regulator.yaml file does not exist
in the repository, as the MT6380 regulator binding is currently a legacy text
file (mt6380-regulator.txt).

This can cause make dt_binding_check to fail when resolving the
cross-reference or silently skip validating the regulators node. Subsequent
patches in the series also do not appear to add the missing YAML file.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921232527.3127894-1-robh@kernel.org?part=1

Re: [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs

From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Date: 2026-09-22 11:45:26

On 9/22/26 01:25, Rob Herring (Arm) wrote:
The MT7622 PMIC wrapper has a regulators child node. Add the child
schema reference so regulator subnodes are evaluated by the MT6380
regulator binding instead of being rejected.

Assisted-by: Codex:gpt-5-5
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH] dt-bindings: soc: mediatek: Allow pwrap regs

From: Rob Herring <robh@kernel.org>
Date: 2026-09-22 19:54:50

On Mon, Sep 21, 2026 at 06:25:26PM -0500, Rob Herring (Arm) wrote:
quoted hunk
The MT7622 PMIC wrapper has a regulators child node. Add the child
schema reference so regulator subnodes are evaluated by the MT6380
regulator binding instead of being rejected.

Assisted-by: Codex:gpt-5-5
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml       | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
index e7c4a3984c60..79b755858bad 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
@@ -105,6 +105,9 @@ properties:
   pmic:
     type: object
 
+  regulators:
+    $ref: /schemas/regulator/mediatek,mt6380-regulator.yaml#
Err, this needs the conversion. Dropping this patch.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help